pst operators: explicit decimal lessThan, lessThanOrEqual, ...#2243
Merged
victornicolet merged 1 commit intomainfrom Mar 23, 2026
Merged
pst operators: explicit decimal lessThan, lessThanOrEqual, ...#2243victornicolet merged 1 commit intomainfrom
victornicolet merged 1 commit intomainfrom
Conversation
Signed-off-by: Victor Nicolet <victornl@amazon.com>
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 100.00% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 86.77% Status: PASSED ✅ Details
|
katherine-hough
approved these changes
Mar 20, 2026
john-h-kastner-aws
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds operators for the
decimallessThan,lessThanOrEqual,greaterThanandgreaterThanOrEqualmethods. Previously, all operations were translated to theLess, LessEq, Greater, GreaterEq(comparisons over the other types) but Cedar represents comparisons over decimals separately.With this we can follow up on cedar-policy/cedar-spec#913 to test AST roundtrip with PST (AST -> PST -> AST).
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):cedar-docs. PRs should be targeted at astaging-X.Ybranch, notmain.)