Include types with HaveReceived failure messages#327
Open
idoru wants to merge 1 commit intocedarbdd:masterfrom
Open
Include types with HaveReceived failure messages#327idoru wants to merge 1 commit intocedarbdd:masterfrom
idoru wants to merge 1 commit intocedarbdd:masterfrom
Conversation
Contributor
|
Thanks @idoru for getting this out there to keep the conversation going. I would prefer not to merge this as-is, because it seems that it decreases the signal-to-noise ratio in the majority of failure cases where type mismatches aren't the cause of the failure. I'm wondering if we can instead have a more specialized failure message that gets triggered when the expectation arguments don't match the types of the actual method. I actually thought we had a behaviour like that in place already, but it doesn't seem to be working as I would have expected. I'll see if I can take a little time to investigate. |
Contributor
Author
|
Yeah, I agree. This was easy enough to do, and I think you're right about the signal-to-noise ratio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of the pain discussed in #326 by including type information with HaveReceived matcher failure messages.
This makes it more obvious when your test fails because your object expects a certain type but your test expectation unintentionally used the wrong type.