Remove webauthn-json dependency#236
Merged
nicolastemciuc merged 3 commits intomasterfrom Aug 11, 2025
Merged
Conversation
With webauthn-json the create() method expects createOptions of type JSON. However, for using the browser's native API, the create() call must receive the options in type CredentialCreationOptions. To pass from JSON to CredentialCreationOptions the method parseRequestOptionsFromJSON is used. parseRequestOptionsFromJSON in turn, expects to receive this format: https://www.w3.org/TR/webauthn-3/#dictdef-publickeycredentialcreationoptionsjson Therefore, the credential ids inside excludeCredentials need to be of type Base64URLString, which is not the case now. As of now, the raw_id is being strict encoded which still doesn't comply with being of type Base64URLString. Instead of strictly encoding the raw_id, the id attribute starts being stored. The id is a base64url encoded version of PublicKeyCredential.rawId.
nicolastemciuc
force-pushed
the
nt--remove-webauthn-json
branch
from
b57deaf to
3f0ebd7
Compare
nicolastemciuc
changed the base branch from
master
to
nt--use-virtual-authenticators-in-test
Base automatically changed from
nt--use-virtual-authenticators-in-test
to
master
August 11, 2025 17:39
santiagorodriguez96
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop using
@github/webauthn-jsondependency and start usingnavigator.credentialsnative API calls instead.Why?
webauthn-jsonhas been deprecated: github/webauthn-json#94