-
-
Notifications
You must be signed in to change notification settings - Fork 18
fix(tsconfig): lowercase module #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cedarjs canceled.
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 2s | View ↗ |
nx run-many -t build |
✅ Succeeded | 3m 35s | View ↗ |
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 4m 15s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 9s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-30 15:14:41 UTC
Greptile OverviewGreptile SummaryThis PR standardizes TypeScript configuration values to use lowercase, aligning with TypeScript's official documentation and IDE intellisense conventions. Changes Made
Files Updated
Impact
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant CLI as Cedar CLI
participant Handler as packageHandler.js
participant FS as File System
participant TS as TypeScript Parser
Dev->>CLI: Generate new package
CLI->>Handler: updateTsconfig()
loop For each target (api, web, scripts)
Handler->>FS: Read tsconfig.json
FS-->>Handler: Return config text
Handler->>TS: parseConfigFileTextToJson()
TS-->>Handler: Parsed config object
alt Has module config
Handler->>Handler: currentModule.toLowerCase()
Handler->>Handler: Check if acceptable value
alt Not acceptable
Handler->>Handler: modify() with lowercase value<br/>(node20, esnext)
Handler->>FS: Write updated tsconfig
FS-->>Handler: Success
else Already acceptable
Handler->>Handler: Skip update
end
else No module config
Handler->>Handler: Skip tsconfig
end
end
Handler-->>CLI: Update complete
CLI-->>Dev: Package generated with<br/>lowercase module values
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, no comments
|
The changes in this PR are now available in 3.0.0-canary.13306+cdce5184d |

The tsconfig json schema currently doesn't support
"module": "Node20", see SchemaStore/schemastore#5326But even if/when that PR gets merged, the intellisense (hover hints/auto complete) will use "node20". And while not 100% consistent, the tsconfig docs also seems to prefer all-lowercase values, listing "node20" as an allowed value

https://www.typescriptlang.org/tsconfig/#module
So this PR switches the "module" value, and a couple of others, to lowercase