Skip to content

Commit 0e76ce7

Browse files
committed
.Net 6 upgrade some minor doc tweaks
#5131
1 parent 249a491 commit 0e76ce7

File tree

4 files changed

+4
-16
lines changed

4 files changed

+4
-16
lines changed

CefSharp.BrowserSubprocess/Program.netcore.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace CefSharp.BrowserSubprocess
99
{
1010
/// <summary>
1111
/// When implementing your own BrowserSubprocess
12-
/// - For .Net use <see cref="BrowserSubprocessExecutable"/> (No WCF Support)
12+
/// - For .Net 6+ use <see cref="BrowserSubprocessExecutable"/> (No WCF Support)
1313
/// - Include an app.manifest with the dpi/compatability sections, this is required (this project contains the relevant).
1414
/// - If you are targeting x86/Win32 then you should set /LargeAddressAware (https://docs.microsoft.com/en-us/cpp/build/reference/largeaddressaware?view=vs-2017)
1515
/// </summary>

CefSharp/WebBrowserExtensions.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -444,9 +444,6 @@ public static Task<LoadUrlAsyncResponse> LoadUrlAsync(IChromiumWebBrowserBase ch
444444
chromiumWebBrowser.LoadError -= loadErrorHandler;
445445
chromiumWebBrowser.LoadingStateChanged -= loadingStateChangeHandler;
446446

447-
//Ensure our continuation is executed on the ThreadPool
448-
//For the .Net implementation we could use
449-
//TaskCreationOptions.RunContinuationsAsynchronously
450447
tcs.TrySetResult(new LoadUrlAsyncResponse(args.ErrorCode, -1));
451448
};
452449

@@ -475,9 +472,6 @@ public static Task<LoadUrlAsyncResponse> LoadUrlAsync(IChromiumWebBrowserBase ch
475472
statusCode = -1;
476473
}
477474

478-
//Ensure our continuation is executed on the ThreadPool
479-
//For the .Net implementation we could use
480-
//TaskCreationOptions.RunContinuationsAsynchronously
481475
tcs.TrySetResult(new LoadUrlAsyncResponse(statusCode == -1 ? CefErrorCode.Failed : CefErrorCode.None, statusCode));
482476
}
483477
};
@@ -540,9 +534,6 @@ public static async Task<WaitForNavigationAsyncResponse> WaitForNavigationAsync(
540534
chromiumWebBrowser.LoadError -= loadErrorHandler;
541535
chromiumWebBrowser.LoadingStateChanged -= loadingStateChangeHandler;
542536

543-
//Ensure our continuation is executed on the ThreadPool
544-
//For the .Net implementation we could use
545-
//TaskCreationOptions.RunContinuationsAsynchronously
546537
tcs.TrySetResult(new WaitForNavigationAsyncResponse(args.ErrorCode, -1));
547538
};
548539

@@ -571,9 +562,6 @@ public static async Task<WaitForNavigationAsyncResponse> WaitForNavigationAsync(
571562
statusCode = -1;
572563
}
573564

574-
//Ensure our continuation is executed on the ThreadPool
575-
//For the .Net implementation we could use
576-
//TaskCreationOptions.RunContinuationsAsynchronously
577565
tcs.TrySetResult(new WaitForNavigationAsyncResponse(statusCode == -1 ? CefErrorCode.Failed : CefErrorCode.None, statusCode));
578566
}
579567
};

NuGet/PackageReference/Readme.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
CefSharp .Net Core/.Net 6.0+ Nuget Package
1+
CefSharp .Net 6.0+ Nuget Package
22

33
Background:
44
CefSharp is a .Net wrapping library for CEF (Chromium Embedded Framework) https://bitbucket.org/chromiumembedded/cef

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ With each release a new branch is created, for example the `92.0.260` release co
8484
If you're new to `CefSharp` and are downloading the source to check it out, please use a **Release** branch.
8585

8686
**&ast;** VC++ 2022 is required starting with version 138<br/>
87-
**&ast;&ast;** For .Net Packages 6 or greater is required.
87+
**&ast;&ast;** For NetCore packages .Net 6 or greater is required.
8888

8989
| Branch | CEF Version | VC++ Version | .Net Version | Status |
9090
|-----------------------------------------------------------------------|------|-------|---------|-----------------|
@@ -169,7 +169,7 @@ If you're new to `CefSharp` and are downloading the source to check it out, plea
169169
| [cefsharp/37](https://github.com/cefsharp/CefSharp/tree/cefsharp/37) | 2062 | 2012 | 4.0 | Unsupported |
170170

171171
**&ast;** VC++ 2022 is required starting with version 138<br/>
172-
**&ast;&ast;** For .Net Packages .Net 6 or greater is required.
172+
**&ast;&ast;** For NetCore packages .Net 6 or greater is required.
173173

174174
## Financial Support
175175

0 commit comments

Comments
 (0)