Core - Reduce ChromiumWebBrowser Code Duplication

- Move events to partial class (where possible)
- Move other explicit interface implementation methods

Issue #3082

Author: amaitland

CefSharp.OffScreen/ChromiumWebBrowser.cs

@@ -51,11 +51,6 @@ public partial class ChromiumWebBrowser : IRenderWebBrowser
         /// </summary>
         private int disposeSignaled;
 
-        /// <summary>
-        /// Used as workaround for issue https://github.com/cefsharp/CefSharp/issues/3021
-        /// </summary>
-        private long canExecuteJavascriptInMainFrameId;
-
         /// <summary>
         /// Gets a value indicating whether this instance is disposed.
         /// </summary>
@@ -123,43 +118,6 @@ public bool IsDisposed
         /// <value>The accessibility handler.</value>
         public IAccessibilityHandler AccessibilityHandler { get; set; }
         /// <summary>
-        /// Event handler that will get called when the resource load for a navigation fails or is canceled.
-        /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
-        /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang..
-        /// To access UI elements you'll need to Invoke/Dispatch onto the UI Thread.
-        /// </summary>
-        public event EventHandler<LoadErrorEventArgs> LoadError;
-        /// <summary>
-        /// Event handler that will get called when the browser begins loading a frame. Multiple frames may be loading at the same
-        /// time. Sub-frames may start or continue loading after the main frame load has ended. This method may not be called for a
-        /// particular frame if the load request for that frame fails. For notification of overall browser load status use
-        /// OnLoadingStateChange instead.
-        /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
-        /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang..
-        /// To access UI elements you'll need to Invoke/Dispatch onto the UI Thread.
-        /// </summary>
-        /// <remarks>Whilst this may seem like a logical place to execute js, it's called before the DOM has been loaded, implement
-        /// <see cref="IRenderProcessMessageHandler.OnContextCreated" /> as it's called when the underlying V8Context is created
-        /// </remarks>
-        public event EventHandler<FrameLoadStartEventArgs> FrameLoadStart;
-        /// <summary>
-        /// Event handler that will get called when the browser is done loading a frame. Multiple frames may be loading at the same
-        /// time. Sub-frames may start or continue loading after the main frame load has ended. This method will always be called
-        /// for all frames irrespective of whether the request completes successfully.
-        /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
-        /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang..
-        /// To access UI elements you'll need to Invoke/Dispatch onto the UI Thread.
-        /// </summary>
-        public event EventHandler<FrameLoadEndEventArgs> FrameLoadEnd;
-        /// <summary>
-        /// Event handler for receiving Javascript console messages being sent from web pages.
-        /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
-        /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang..
-        /// To access UI elements you'll need to Invoke/Dispatch onto the UI Thread.
-        /// (The exception to this is when your running with settings.MultiThreadedMessageLoop = false, then they'll be the same thread).
-        /// </summary>
-        public event EventHandler<ConsoleMessageEventArgs> ConsoleMessage;
-        /// <summary>
         /// Event called after the underlying CEF browser instance has been created. 
         /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
         /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang..
@@ -168,24 +126,7 @@ public bool IsDisposed
         /// </summary>
         public event EventHandler BrowserInitialized;
         /// <summary>
-        /// Event handler for changes to the status message.
-        /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
-        /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang.
-        /// To access UI elements you'll need to Invoke/Dispatch onto the UI Thread.
-        /// (The exception to this is when your running with settings.MultiThreadedMessageLoop = false, then they'll be the same thread).
-        /// </summary>
-        public event EventHandler<StatusMessageEventArgs> StatusMessage;
-        /// <summary>
-        /// Event handler that will get called when the Loading state has changed.
-        /// This event will be fired twice. Once when loading is initiated either programmatically or
-        /// by user action, and once when loading is terminated due to completion, cancellation of failure.
-        /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
-        /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang..
-        /// To access UI elements you'll need to Invoke/Dispatch onto the UI Thread.
-        /// </summary>
-        public event EventHandler<LoadingStateChangedEventArgs> LoadingStateChanged;
-        /// <summary>
-        /// Occurs when [address changed].
+        /// Occurs when the browser address changed.
         /// It's important to note this event is fired on a CEF UI thread, which by default is not the same as your application UI
         /// thread. It is unwise to block on this thread for any length of time as your browser will become unresponsive and/or hang..
         /// To access UI elements you'll need to Invoke/Dispatch onto the UI Thread.
@@ -216,19 +157,7 @@ public bool IsDisposed
         private event EventHandler<OnPaintEventArgs> AfterPaint;
 
         /// <summary>
-        /// Event handler that will get called when the message that originates from CefSharp.PostMessage
-        /// </summary>
-        public event EventHandler<JavascriptMessageReceivedEventArgs> JavascriptMessageReceived;
-
-        /// <summary>
-        /// A flag that indicates if you can execute javascript in the main frame.
-        /// Flag is set to true in IRenderProcessMessageHandler.OnContextCreated.
-        /// and false in IRenderProcessMessageHandler.OnContextReleased
-        /// </summary>
-        public bool CanExecuteJavascriptInMainFrame { get; private set; }
-
-        /// <summary>
-        /// Create a new OffScreen Chromium Browser. If you use <see cref="JavascriptBindingSettings.LegacyBindingEnabled"/> = true then you must
+        /// Create a new OffScreen Chromium Browser. If you use <see cref="CefSharp.JavascriptBinding.JavascriptBindingSettings.LegacyBindingEnabled"/> = true then you must
         /// set <paramref name="automaticallyCreateBrowser"/> to false and call <see cref="CreateBrowser"/> after the objects are registered.
         /// </summary>
         /// <param name="html">html string to be initially loaded in the browser.</param>
@@ -242,7 +171,7 @@ public ChromiumWebBrowser(HtmlString html, BrowserSettings browserSettings = nul
         }
 
         /// <summary>
-        /// Create a new OffScreen Chromium Browser. If you use <see cref="JavascriptBindingSettings.LegacyBindingEnabled"/> = true then you must
+        /// Create a new OffScreen Chromium Browser. If you use <see cref="CefSharp.JavascriptBinding.JavascriptBindingSettings.LegacyBindingEnabled"/> = true then you must
         /// set <paramref name="automaticallyCreateBrowser"/> to false and call <see cref="CreateBrowser"/> after the objects are registered.
         /// </summary>
         /// <param name="address">Initial address (url) to load</param>
@@ -725,33 +654,6 @@ void IRenderWebBrowser.OnVirtualKeyboardRequested(IBrowser browser, TextInputMod
             RenderHandler?.OnVirtualKeyboardRequested(browser, inputMode);
         }
 
-        /// <summary>
-        /// Handles the <see cref="E:ConsoleMessage" /> event.
-        /// </summary>
-        /// <param name="args">The <see cref="ConsoleMessageEventArgs"/> instance containing the event data.</param>
-        void IWebBrowserInternal.OnConsoleMessage(ConsoleMessageEventArgs args)
-        {
-            ConsoleMessage?.Invoke(this, args);
-        }
-
-        /// <summary>
-        /// Handles the <see cref="E:FrameLoadStart" /> event.
-        /// </summary>
-        /// <param name="args">The <see cref="FrameLoadStartEventArgs"/> instance containing the event data.</param>
-        void IWebBrowserInternal.OnFrameLoadStart(FrameLoadStartEventArgs args)
-        {
-            FrameLoadStart?.Invoke(this, args);
-        }
-
-        /// <summary>
-        /// Handles the <see cref="E:FrameLoadEnd" /> event.
-        /// </summary>
-        /// <param name="args">The <see cref="FrameLoadEndEventArgs"/> instance containing the event data.</param>
-        void IWebBrowserInternal.OnFrameLoadEnd(FrameLoadEndEventArgs args)
-        {
-            FrameLoadEnd?.Invoke(this, args);
-        }
-
         /// <summary>
         /// Called when [after browser created].
         /// </summary>
@@ -765,39 +667,6 @@ void IWebBrowserInternal.OnAfterBrowserCreated(IBrowser browser)
             BrowserInitialized?.Invoke(this, EventArgs.Empty);
         }
 
-        /// <summary>
-        /// Handles the <see cref="E:LoadError" /> event.
-        /// </summary>
-        /// <param name="args">The <see cref="LoadErrorEventArgs"/> instance containing the event data.</param>
-        void IWebBrowserInternal.OnLoadError(LoadErrorEventArgs args)
-        {
-            LoadError?.Invoke(this, args);
-        }
-
-        /// <summary>
-        /// Gets the browser adapter.
-        /// </summary>
-        /// <value>The browser adapter.</value>
-        IBrowserAdapter IWebBrowserInternal.BrowserAdapter
-        {
-            get { return managedCefBrowserAdapter; }
-        }
-
-        /// <summary>
-        /// Gets or sets a value indicating whether this instance has parent.
-        /// </summary>
-        /// <value><c>true</c> if this instance has parent; otherwise, <c>false</c>.</value>
-        bool IWebBrowserInternal.HasParent { get; set; }
-
-        /// <summary>
-        /// Handles the <see cref="E:StatusMessage" /> event.
-        /// </summary>
-        /// <param name="args">The <see cref="StatusMessageEventArgs"/> instance containing the event data.</param>
-        void IWebBrowserInternal.OnStatusMessage(StatusMessageEventArgs args)
-        {
-            StatusMessage?.Invoke(this, args);
-        }
-
         /// <summary>
         /// Sets the address.
         /// </summary>
@@ -840,29 +709,6 @@ void IWebBrowserInternal.SetTooltipText(string tooltipText)
             TooltipText = tooltipText;
         }
 
-        void IWebBrowserInternal.SetCanExecuteJavascriptOnMainFrame(long frameId, bool canExecute)
-        {
-            //When loading pages of a different origin the frameId changes
-            //For the first loading of a new origin the messages from the render process
-            //Arrive in a different order than expected, the OnContextCreated message
-            //arrives before the OnContextReleased, then the message for OnContextReleased
-            //incorrectly overrides the value
-            //https://github.com/cefsharp/CefSharp/issues/3021
-
-            if (frameId > canExecuteJavascriptInMainFrameId && !canExecute)
-            {
-                return;
-            }
-
-            canExecuteJavascriptInMainFrameId = frameId;
-            CanExecuteJavascriptInMainFrame = canExecute;
-        }
-
-        void IWebBrowserInternal.SetJavascriptMessageReceived(JavascriptMessageReceivedEventArgs args)
-        {
-            JavascriptMessageReceived?.Invoke(this, args);
-        }
-
         /// <summary>
         /// Creates a new bitmap with the dimensions of firstBitmap, then
         /// draws the firstBitmap, then overlays the secondBitmap