Fixed message interceptor not working after a render process switch #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er process switch
|
✅ Build CefSharp 71.0.0-CI2942 completed (commit 676fca8ec4 by @merceyz) |
|
✅ Build CefSharp 71.0.0-CI2943 completed (commit ee384f8025 by @merceyz) |
|
✅ Build CefSharp 71.0.0-CI2945 completed (commit d2b59c26f6 by @amaitland) |
Member
|
I haven't had a chance to run it yet, just looking at the code, looks like a very neat and tidy solution 👍 It's probably worth adding some background comments as to what's going on, that shouldn't necessarily stop this from being merged. |
merceyz
commented
Feb 19, 2019
|
✅ Build CefSharp 71.0.0-CI2956 completed (commit 453fc7704d by @merceyz) |
Member
|
Added an extra comment in 574bc16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChromeWidgetMessageInterceptorset itself up again after a render process switch happensFixes #2579