Skip to content

Conversation

@merceyz
Copy link
Member

@merceyz merceyz commented Mar 9, 2019

  • Moved conversion of CefNavigationEntry -> NavigationEntry to CefSharp.Core\Internals\TypeConversion.h

The conversion of CefNavigationEntry -> NavigationEntry was duplicated in

  • CefSharp.Core\Internals\CefNavigationEntryVisitorAdapter.h
  • CefSharp.Core\Internals\CefBrowserHostWrapper.cpp

@merceyz merceyz added this to the 73.0.0 milestone Mar 9, 2019
@AppVeyorBot
Copy link

@amaitland
Copy link
Member

Thanks 👍 Will need to take this for a spin before merging as the code was restructured. A quick glance and it looks fine.

@AppVeyorBot
Copy link

@amaitland amaitland merged commit 12b27f9 into cefsharp:master Mar 23, 2019
@amaitland
Copy link
Member

I rebased this locally which GitHub didn't seem to recognise, so effectively this was merged in 58e8a29

Added additional null check in 1a2d4a8 and improved xml doc slightly for SslStatus.CertStatus

@merceyz
Copy link
Member Author

merceyz commented Mar 23, 2019

I rebased this locally which GitHub didn't seem to recognise

To edit this PR so that GitHub notices it, you'd have to get my fork and push to the branch this PR is pointed to

@merceyz merceyz deleted the refactoring-navigationentry-convert branch March 23, 2019 12:33
@amaitland
Copy link
Member

I know, I was trying to be lazy 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants