Reorder dispose pattern in ChromiumWebBrowser

[amaitland]

WinForms/Wpf/OffScreen - Reorder Dispose methods

• Set browser initialized to false
• Release event handlers
• Dispose managedCefBrowserAdapter
• Set handlers to null

Follow up to #2651

[amaitland]

All three controls should be roughly the same in order now. Releasing the event handlers before Disposing of ManagedCefBrowserAdapter should keep the events from being fired mid Dispose.

I'm also considering freeing the handlers earlier and just setting ILifeSpanHandler = null after ManagedCefBrowserAdapter.Dispose

[AppVeyorBot]

✅ Build CefSharp 73.0.0-CI3022 completed (commit 52b3c59655 by @amaitland)

[merceyz]

Looks good

[merceyz]

I'm also considering freeing the handlers earlier and just setting ILifeSpanHandler = null after ManagedCefBrowserAdapter.Dispose

Is it an option to set all handlers to null before that call, then have it handle the logic of closing the browser further down the stack?

[amaitland]

Is it an option to set all handlers to null before that call

All handlers except LifeSpanHandler. It has to be freed after otherwise LifeSpanHandler.DoClose won't be called. See https://github.com/cefsharp/CefSharp/blob/cefsharp/71/CefSharp.Wpf/ChromiumWebBrowser.cs#L642

[AppVeyorBot]

✅ Build CefSharp 73.0.0-CI3034 completed (commit 13f6430a26 by @amaitland)

[amaitland]

LifeSpanHandler is now set to null independently of the other handlers which are set to null after the event handlers.