Skip to content

Refactoring - Move Register(async)JsObject to WebBrowserExtensions #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amaitland merged 3 commits into from
Mar 23, 2019
Merged

Refactoring - Move Register(async)JsObject to WebBrowserExtensions #2703

amaitland merged 3 commits into from
Mar 23, 2019

Conversation

@merceyz
Copy link
Member

@merceyz merceyz commented Mar 22, 2019

  • Removed RegisterJsObject and RegisterAsyncJsObject from
    • IWebBrowser
    • OffScreen\ChromiumWebBrowser
    • Wpf\ChromiumWebBrowser
    • WinForms\ChromiumWebBrowser
  • CefSharp\WebBrowserExtensions added
    • ValidateBrowserBeforeRegistering
    • RegisterJsObject
    • RegisterAsyncJsObject
    • ThrowExceptionIfDisposed
  • WinForms\ChromiumWebBrowser
    • Added InitializeFieldsAndCefIfRequired to the getter for JavascriptObjectRepository

@merceyz merceyz added this to the 73.0.0 milestone Mar 22, 2019
@AppVeyorBot
Copy link

AppVeyorBot commented Mar 22, 2019

✅ Build CefSharp 73.0.0-CI3027 completed (commit c5cf745274 by @merceyz)

@amaitland amaitland merged commit 987f988 into cefsharp:master Mar 23, 2019
@amaitland
Copy link
Member

amaitland commented Mar 23, 2019

Just need a short 1-2 lines for inclusion in the Breaking Changes of the release notes, shouldn't need more than just to make sure they have a using CefSharp; entry.

@merceyz
Copy link
Member Author

merceyz commented Mar 23, 2019

Correct, users of RegisterJsObject and RegisterAsyncJsObject need to add a using CefSharp; entry

@merceyz merceyz deleted the refactoring-legacy-binding branch March 23, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking-change code-cleanup enhancement offscreen winforms wpf WPF Implementation

Projects

None yet

Milestone

73.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@merceyz @AppVeyorBot @amaitland