Check for colon for time when searching for time#16
Open
djrcawley wants to merge 2 commits intocelebi-pkg:mainfrom
Open
Check for colon for time when searching for time#16djrcawley wants to merge 2 commits intocelebi-pkg:mainfrom
djrcawley wants to merge 2 commits intocelebi-pkg:mainfrom
Conversation
Author
|
Hello, I'm still pretty new to github and want to contribute where I can, so I apologize if my formatting is not the best. The issue I found, while very small, occurs anytime the airline LATAM is scraped. Since args checks for strings containing "AM" and formats them to a datetime. Instead, I added another check to verify if a colon was included in each string before it is formatted to a datetime. Let me know if you have any other suggestions. I know this isn't a major issue, but hoped to still contribute anyways. @kcelebi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for colon when scraping and converting to date-time. Airline LATAM creates a Value Error when we check solely for 'AM' and 'PM'