Skip to content

Conversation

@sethrj
Copy link
Member

@sethrj sethrj commented Oct 12, 2025

No description provided.

@sethrj sethrj requested a review from Copilot October 12, 2025 19:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates enum values to use uppercase naming convention for PEP compliance, migrating from snake_case to UPPER_CASE enum members while maintaining backward compatibility through deprecated lowercase aliases.

  • Updates all enum definitions to use StrEnum and auto() for consistent uppercase values
  • Maintains backward compatibility by providing lowercase aliases for existing enum members
  • Updates test files and configuration to use the new uppercase enum values

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
celerpy/model.py Converts enums to StrEnum with uppercase values and backward compatibility aliases
celerpy/conf/settings.py Imports LogLevel from model.py and updates default values to uppercase
celerpy/visualize.py Updates enum references to use uppercase values and adds visualization improvements
test/test_visualize.py Updates test code to use uppercase enum values
test/test_model.py Adds test to verify backward compatibility of lowercase enum values
pyproject.toml Removes numpy mypy plugin
requirements-dev.txt Updates development dependencies to newer versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sethrj sethrj merged commit 6862d24 into celeritas-project:main Oct 17, 2025
7 checks passed
@sethrj sethrj deleted the uppercase-enums branch October 17, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant