Conversation
There was a problem hiding this comment.
Pull request overview
Adds Django 6.0 as a supported/tested Django version across local tox environments and packaging metadata.
Changes:
- Expand tox env matrix to include
django60(Python 3.12/3.13) and wire in a new Django 6.0 test requirements file. - Add a
Framework :: Django :: 6.0Trove classifier to package metadata. - Broaden the generic Django test dependency upper bound from
<6.0to<7.0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tox.ini |
Adds django60 to envlist and tox dependency factor mapping. |
setup.py |
Declares Django 6.0 support via Trove classifier. |
requirements/test-django60.txt |
New requirements pin for Django 6.x testing. |
requirements/test-django.txt |
Raises Django upper bound to allow 6.x in generic test deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| py313-django{51,52,60} | ||
| py312-django{51,52,60,42} |
There was a problem hiding this comment.
The GitHub Actions unittest matrix currently only runs Django {32,42,51,52} and does not include the new django60 tox environments. As a result, the newly added Django 6.0 support won’t be exercised in CI; please update the CI matrix (e.g., .github/workflows/test.yaml) to add the appropriate Django=60 combinations (likely py312/py313 only, matching tox envlist).
There was a problem hiding this comment.
@awais786 please cross check this, this might be missing
Removed celery<6.0 from default.txt to avoid conflict with Django 6.0. Excluded Python 3.11 + Django 6.0 from CI, as Django 6.0 requires Python 3.12+.
Removed celery<6.0 from default.txt to avoid conflict with Django 6.0. Excluded Python 3.11 + Django 6.0 from CI, as Django 6.0 requires Python 3.12+.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| celery>=5.2.7 | ||
| Django>=3.2.25 |
There was a problem hiding this comment.
The PR is titled/descried as adding Django 6 support, but this hunk also removes the upper bound on Celery (previously <6.0). Since requirements/default.txt feeds install_requires in setup.py, this broadens the supported/runtime dependency range and may allow Celery 6+ to be installed without any corresponding compatibility/testing updates (and requirements/docs.txt still caps Celery at <6.0). If the intent is to support Celery 6, please update the PR description and align constraints across requirement files; otherwise, consider restoring an upper bound (or choosing a new tested range, e.g. <7.0).
Adding django6 support.