chore: switch to using cross compilation instead of docker for building talis binaries #6272
+21
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove tools/talis/docker/Dockerfile - Update tools/talis/README.md to reflect that local build is used - (Makefile, go.mod, go.sum changes are included as they were part of the optimization) Co-authored-by: Hlib Kanunnikov <[email protected]>
evan-forbes
requested review from
cmwaters,
ninabarbakadze and
rach-id
as code owners
evan-forbes
added
the
WS: Maintenance 🔧
|
evan-forbes
added
the
priority:low
Member
Author
|
@copilot fix the ci here by calling go mod tidy in tastora and/whatever else is required |
Contributor
|
@evan-forbes I've opened a new pull request, #6273, to work on those changes. Once the pull request is ready, I'll request review from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple optimization for make build-talis-bins