fix: warn and override non-CAT mempool type#6574
Merged
rootulp merged 6 commits intocelestiaorg:mainfrom Feb 18, 2026
Merged
Conversation
rootulp
requested review from
cmwaters,
evan-forbes,
ninabarbakadze and
rach-id
as code owners
rootulp
commented
Feb 14, 2026
docs/release-notes/release-notes.md
Outdated
| #### Config Changes | ||
|
|
||
| No configuration changes are required for v7. Existing v6 configurations remain compatible. | ||
| celestia-app now returns a startup error if the mempool type is not `cat`. Previously, non-CAT mempool types (e.g. `flood`) were silently overridden to `cat` at startup. If your `config.toml` uses a different mempool type, update the `[mempool]` section: |
Collaborator
Author
There was a problem hiding this comment.
This isn't technically true because the override would log a message.
rach-id
reviewed
Feb 16, 2026
Member
rach-id
left a comment
rach-id
left a comment
There was a problem hiding this comment.
IMO we should just remove the config from config.toml. It's easier to just run the binary than to read the logs, see what's wrong, etc
Collaborator
Author
|
FLUPs:
|
rootulp
changed the title
rootulp
changed the title
rootulp
changed the title
Replace the silent override of non-CAT mempool types with a hard startup error. Previously, celestia-app silently changed flood mempools to CAT, masking misconfiguration. Now operators must explicitly set type = "cat" in the [mempool] section of config.toml. The mempool type validation runs before the bypass-config-overrides flag check because non-CAT mempools are fundamentally unsupported. Closes celestiaorg#6573 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of returning a startup error for non-CAT mempool types, warn and override to CAT. This is less disruptive for existing users whose config.toml may still contain a mempool type field. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rootulp
force-pushed
the
rootulp/error-on-non-cat-mempool
branch
from
163ece0 to
6c7bbe8
Compare
rach-id
previously approved these changes
Feb 17, 2026
ninabarbakadze
previously approved these changes
Feb 17, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rootulp
requested review from
ninabarbakadze and
rach-id
and removed request for
cmwaters and
evan-forbes
…n-cat-mempool # Conflicts: # Makefile
ninabarbakadze
approved these changes
Feb 18, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6573
Blocked on a release with celestiaorg/celestia-core#2811
Summary
overrideMempoolTypefunction that runs before the bypass-config-overrides flag check (non-CAT mempools are fundamentally unsupported and must not be bypassable)overrideMempoolConfigA companion PR in celestia-core removes the mempool
typefield from the config.toml template so new config files no longer expose it: celestiaorg/celestia-core#2811Test plan
make buildcompiles successfullygo test -v -run TestOverrideP2PConfig ./cmd/celestia-appd/cmd/— all tests passgo test -v -run TestOverrideMempoolType ./cmd/celestia-appd/cmd/— unit tests passmarkdownlint docs/release-notes/release-notes.md— no lint errorstype = "flood"in config.toml starts with a warning and overrides to CATtype = "cat"starts normally without a warning--bypass-config-overridesdoes NOT bypass the mempool type override🤖 Generated with Claude Code