chore(deps): bump core to v0.40.0 and go to v1.26.1 - #6872
Merged
Conversation
rach-id
commented
Mar 17, 2026
| # Before upgrading the GOLANG_CROSS_VERSION, please verify that a Docker image exists with the new tag. | ||
| # See https://github.com/goreleaser/goreleaser-cross/pkgs/container/goreleaser-cross | ||
| GOLANG_CROSS_VERSION ?= v1.25.8 | ||
| GOLANG_CROSS_VERSION ?= v1.26.1 |
Member
Author
There was a problem hiding this comment.
Will create an issue for this
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
evan-forbes
previously approved these changes
Mar 17, 2026
Member
Author
|
Let's not merge until: goreleaser/goreleaser-cross#134 is merged/released |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rach-id
marked this pull request as draft
March 17, 2026 17:01
…Cloud utility functions
# Conflicts: # go.mod
rach-id
marked this pull request as ready for review
March 19, 2026 20:04
rach-id
enabled auto-merge
March 19, 2026 20:04
ninabarbakadze
approved these changes
Mar 19, 2026
rach-id
added a commit
that referenced
this pull request
Jun 4, 2026
## Problem Recent releases (`v9.0.0-*`, `v9.0.1-*`, `v9.0.2-*`) shipped with **no goreleaser binaries** attached — only GitHub's auto-generated source archives show up. The release binaries (multiplexer + standalone for darwin/linux × amd64/arm64, plus `checksums.txt`) are missing. ## Root cause The `goreleaser` CI job is gated on `needs: goreleaser-check`, and `goreleaser-check` was failing on every release with: ``` docker: Error response from daemon: manifest unknown make: *** [Makefile:525: goreleaser-check] Error 125 ``` `Makefile` pinned `GOLANG_CROSS_VERSION ?= v1.26.1` (set in #6872 to match the Go bump to 1.26.1), but **goreleaser-cross never published an image tagged `v1.26.1`** — it skipped the `.1` patch for the Go 1.26 line. Only `v1.26.0`, `v1.26.2`, and `v1.26.3` exist in `ghcr.io/goreleaser/goreleaser-cross`. So Docker fails with `manifest unknown`, the check job dies, and the dependent `goreleaser` job is skipped → no binaries uploaded. This never blocked the release from being *created*, so it was a silent failure. ## Fix Pin to `v1.26.2`, a published image whose Go version satisfies the `go.mod` requirement (`go 1.26.1`). ## Follow-up Existing releases that shipped without binaries will need their `goreleaser` workflow re-run (or be re-published) once this lands so the assets get backfilled. 🤖 Generated with [Claude Code](https://claude.com/claude-code)<hr>This is an automatic backport of pull request #7353 done by [Mergify](https://mergify.com). Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
walldiss
pushed a commit
to walldiss/celestia-app
that referenced
this pull request
Jun 9, 2026
## Problem Recent releases (`v9.0.0-*`, `v9.0.1-*`, `v9.0.2-*`) shipped with **no goreleaser binaries** attached — only GitHub's auto-generated source archives show up. The release binaries (multiplexer + standalone for darwin/linux × amd64/arm64, plus `checksums.txt`) are missing. ## Root cause The `goreleaser` CI job is gated on `needs: goreleaser-check`, and `goreleaser-check` was failing on every release with: ``` docker: Error response from daemon: manifest unknown make: *** [Makefile:525: goreleaser-check] Error 125 ``` `Makefile` pinned `GOLANG_CROSS_VERSION ?= v1.26.1` (set in celestiaorg#6872 to match the Go bump to 1.26.1), but **goreleaser-cross never published an image tagged `v1.26.1`** — it skipped the `.1` patch for the Go 1.26 line. Only `v1.26.0`, `v1.26.2`, and `v1.26.3` exist in `ghcr.io/goreleaser/goreleaser-cross`. So Docker fails with `manifest unknown`, the check job dies, and the dependent `goreleaser` job is skipped → no binaries uploaded. This never blocked the release from being *created*, so it was a silent failure. ## Fix Pin to `v1.26.2`, a published image whose Go version satisfies the `go.mod` requirement (`go 1.26.1`). ## Follow-up Existing releases that shipped without binaries will need their `goreleaser` workflow re-run (or be re-published) once this lands so the assets get backfilled. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
bumps core to v0.40.0 and go to v1.26.1