feat: generate a commented out config.toml so defaults can be changed #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
evan-forbes and
rach-id
and removed request for
a team
Member
|
we just need to make sure that we document this and, imo, only include in v4 since this could break any scripts that change values |
rach-id
previously approved these changes
Nov 20, 2024
Member
rach-id
left a comment
rach-id
left a comment
There was a problem hiding this comment.
I like this. Can you fix the misspelling please?
rootulp
previously approved these changes
Nov 20, 2024
Co-authored-by: Rootul P <[email protected]>
cmwaters
dismissed stale reviews from rootulp, rach-id, and evan-forbes
via
ab7b834
Contributor
Author
How do we do that? |
rootulp
previously approved these changes
Nov 21, 2024
Contributor
Author
|
Closing in favour of #1868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested this using the
single-node.shscript in celestia-app. Note that the moniker should stay as it's set in the init and sometimes used by the CLICloses: #1518
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments