chore(lifecycle): disable service breaker (#4759)

Author: vgonkivs

nodebuilder/das/constructors.go

@@ -11,9 +11,7 @@ import (
 
 	"github.com/celestiaorg/celestia-node/das"
 	"github.com/celestiaorg/celestia-node/header"
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 	"github.com/celestiaorg/celestia-node/share"
-	"github.com/celestiaorg/celestia-node/share/eds/byzantine"
 	"github.com/celestiaorg/celestia-node/share/shwap/p2p/shrex/shrexsub"
 )
 
@@ -45,15 +43,6 @@ func newDASer(
 	fraudServ fraud.Service[*header.ExtendedHeader],
 	bFn shrexsub.BroadcastFn,
 	options ...das.Option,
-) (*das.DASer, *modfraud.ServiceBreaker[*das.DASer, *header.ExtendedHeader], error) {
-	ds, err := das.NewDASer(da, hsub, store, batching, fraudServ, bFn, options...)
-	if err != nil {
-		return nil, nil, err
-	}
-
-	return ds, &modfraud.ServiceBreaker[*das.DASer, *header.ExtendedHeader]{
-		Service:   ds,
-		FraudServ: fraudServ,
-		FraudType: byzantine.BadEncoding,
-	}, nil
+) (*das.DASer, error) {
+	return das.NewDASer(da, hsub, store, batching, fraudServ, bFn, options...)
 }

nodebuilder/das/module.go

@@ -6,8 +6,6 @@ import (
 	"go.uber.org/fx"
 
 	"github.com/celestiaorg/celestia-node/das"
-	"github.com/celestiaorg/celestia-node/header"
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 	"github.com/celestiaorg/celestia-node/nodebuilder/node"
 )
 
@@ -41,11 +39,11 @@ func ConstructModule(tp node.Type, cfg *Config) fx.Option {
 		baseComponents,
 		fx.Provide(fx.Annotate(
 			newDASer,
-			fx.OnStart(func(ctx context.Context, breaker *modfraud.ServiceBreaker[*das.DASer, *header.ExtendedHeader]) error {
-				return breaker.Start(ctx)
+			fx.OnStart(func(ctx context.Context, daser *das.DASer) error {
+				return daser.Start(ctx)
 			}),
-			fx.OnStop(func(ctx context.Context, breaker *modfraud.ServiceBreaker[*das.DASer, *header.ExtendedHeader]) error {
-				return breaker.Stop(ctx)
+			fx.OnStop(func(ctx context.Context, daser *das.DASer) error {
+				return daser.Stop(ctx)
 			}),
 		)),
 		// Module is needed for the RPC handler

nodebuilder/header/constructors.go

@@ -10,16 +10,13 @@ import (
 	"github.com/libp2p/go-libp2p/p2p/net/conngater"
 	"go.uber.org/fx"
 
-	libfraud "github.com/celestiaorg/go-fraud"
 	libhead "github.com/celestiaorg/go-header"
 	"github.com/celestiaorg/go-header/p2p"
 	"github.com/celestiaorg/go-header/store"
 	"github.com/celestiaorg/go-header/sync"
 
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 	"github.com/celestiaorg/celestia-node/nodebuilder/node"
 	modp2p "github.com/celestiaorg/celestia-node/nodebuilder/p2p"
-	"github.com/celestiaorg/celestia-node/share/eds/byzantine"
 )
 
 // newP2PExchange constructs a new Exchange for headers.
@@ -106,17 +103,6 @@ func newSyncer[H libhead.Header[H]](
 	return syncer, nil
 }
 
-func newFraudedSyncer[H libhead.Header[H]](
-	fservice libfraud.Service[H],
-	syncer *sync.Syncer[H],
-) *modfraud.ServiceBreaker[*sync.Syncer[H], H] {
-	return &modfraud.ServiceBreaker[*sync.Syncer[H], H]{
-		Service:   syncer,
-		FraudType: byzantine.BadEncoding,
-		FraudServ: fservice,
-	}
-}
-
 // newStore constructs an initialized store
 func newStore[H libhead.Header[H]](
 	lc fx.Lifecycle,

nodebuilder/header/module.go

@@ -16,7 +16,6 @@ import (
 
 	"github.com/celestiaorg/celestia-node/header"
 	"github.com/celestiaorg/celestia-node/libs/pidstore"
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 	"github.com/celestiaorg/celestia-node/nodebuilder/node"
 	modp2p "github.com/celestiaorg/celestia-node/nodebuilder/p2p"
 )
@@ -35,12 +34,11 @@ func ConstructModule[H libhead.Header[H]](tp node.Type, cfg *Config) fx.Option {
 		fx.Provide(func(subscriber *p2p.Subscriber[H]) libhead.Subscriber[H] {
 			return subscriber
 		}),
-		fx.Provide(newSyncer[H]),
 		fx.Provide(fx.Annotate(
-			newFraudedSyncer[H],
+			newSyncer[H],
 			fx.OnStart(func(
 				ctx context.Context,
-				breaker *modfraud.ServiceBreaker[*sync.Syncer[H], H],
+				syncer *sync.Syncer[H],
 			) error {
 				// TODO(@Wondertan): This fix flakes in e2e tests
 				//  This is coming from the store asynchronity.
@@ -49,13 +47,13 @@ func ConstructModule[H libhead.Header[H]](tp node.Type, cfg *Config) fx.Option {
 				//  However, the Store doesn't makes it immediately available causing flakes
 				//  The proper fix will be in a follow up release after pruning.
 				defer time.Sleep(time.Millisecond * 100)
-				return breaker.Start(ctx)
+				return syncer.Start(ctx)
 			}),
 			fx.OnStop(func(
 				ctx context.Context,
-				breaker *modfraud.ServiceBreaker[*sync.Syncer[H], H],
+				syncer *sync.Syncer[H],
 			) error {
-				return breaker.Stop(ctx)
+				return syncer.Stop(ctx)
 			}),
 		)),
 		fx.Provide(fx.Annotate(

nodebuilder/header/service.go

@@ -13,7 +13,6 @@ import (
 
 	"github.com/celestiaorg/celestia-node/header"
 	"github.com/celestiaorg/celestia-node/libs/utils"
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 )
 
 var tracer = otel.Tracer("header/service")
@@ -41,14 +40,13 @@ type syncer interface {
 
 // newHeaderService creates a new instance of header Service.
 func newHeaderService(
-	// getting Syncer wrapped in ServiceBreaker so we ensure service breaker is constructed
-	syncer *modfraud.ServiceBreaker[*sync.Syncer[*header.ExtendedHeader], *header.ExtendedHeader],
+	syncer *sync.Syncer[*header.ExtendedHeader],
 	sub libhead.Subscriber[*header.ExtendedHeader],
 	p2pServer *p2p.ExchangeServer[*header.ExtendedHeader],
 	store libhead.Store[*header.ExtendedHeader],
 ) Module {
 	return &Service{
-		syncer:    syncer.Service,
+		syncer:    syncer,
 		sub:       sub,
 		p2pServer: p2pServer,
 		store:     store,

nodebuilder/pruner/constructors.go

@@ -7,14 +7,13 @@ import (
 	headsync "github.com/celestiaorg/go-header/sync"
 
 	"github.com/celestiaorg/celestia-node/header"
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 	"github.com/celestiaorg/celestia-node/nodebuilder/p2p"
 	modshare "github.com/celestiaorg/celestia-node/nodebuilder/share"
 	"github.com/celestiaorg/celestia-node/pruner"
 )
 
 // ensures Pruner always starts after Syncer
-type syncerAnchor = modfraud.ServiceBreaker[*headsync.Syncer[*header.ExtendedHeader], *header.ExtendedHeader]
+type syncerAnchor = headsync.Syncer[*header.ExtendedHeader]
 
 func newPrunerService(
 	p pruner.Pruner,

nodebuilder/state/core.go

@@ -4,14 +4,11 @@ import (
 	"github.com/cosmos/cosmos-sdk/crypto/keyring"
 	"google.golang.org/grpc"
 
-	libfraud "github.com/celestiaorg/go-fraud"
 	"github.com/celestiaorg/go-header/sync"
 
 	"github.com/celestiaorg/celestia-node/header"
 	"github.com/celestiaorg/celestia-node/nodebuilder/core"
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 	"github.com/celestiaorg/celestia-node/nodebuilder/p2p"
-	"github.com/celestiaorg/celestia-node/share/eds/byzantine"
 	"github.com/celestiaorg/celestia-node/state"
 )
 
@@ -22,14 +19,12 @@ func coreAccessor(
 	keyring keyring.Keyring,
 	keyname AccountName,
 	sync *sync.Syncer[*header.ExtendedHeader],
-	fraudServ libfraud.Service[*header.ExtendedHeader],
 	network p2p.Network,
 	client *grpc.ClientConn,
 	additionalConns core.AdditionalCoreConns,
 ) (
 	*state.CoreAccessor,
 	Module,
-	*modfraud.ServiceBreaker[*state.CoreAccessor, *header.ExtendedHeader],
 	error,
 ) {
 	var opts []state.Option
@@ -51,10 +46,5 @@ func coreAccessor(
 
 	ca, err := state.NewCoreAccessor(keyring, string(keyname), sync, client, network.String(), nil, opts...)
 
-	sBreaker := &modfraud.ServiceBreaker[*state.CoreAccessor, *header.ExtendedHeader]{
-		Service:   ca,
-		FraudType: byzantine.BadEncoding,
-		FraudServ: fraudServ,
-	}
-	return ca, ca, sBreaker, err
+	return ca, ca, err
 }

nodebuilder/state/module.go

@@ -7,11 +7,9 @@ import (
 	logging "github.com/ipfs/go-log/v2"
 	"go.uber.org/fx"
 
-	"github.com/celestiaorg/celestia-node/header"
 	"github.com/celestiaorg/celestia-node/libs/fxutil"
 	"github.com/celestiaorg/celestia-node/libs/keystore"
 	"github.com/celestiaorg/celestia-node/nodebuilder/core"
-	modfraud "github.com/celestiaorg/celestia-node/nodebuilder/fraud"
 	"github.com/celestiaorg/celestia-node/nodebuilder/node"
 	"github.com/celestiaorg/celestia-node/state"
 )
@@ -31,15 +29,11 @@ func ConstructModule(tp node.Type, cfg *Config, coreCfg *core.Config) fx.Option
 		}),
 		fxutil.ProvideIf(coreCfg.IsEndpointConfigured(), fx.Annotate(
 			coreAccessor,
-			fx.OnStart(func(ctx context.Context,
-				breaker *modfraud.ServiceBreaker[*state.CoreAccessor, *header.ExtendedHeader],
-			) error {
-				return breaker.Start(ctx)
+			fx.OnStart(func(ctx context.Context, state *state.CoreAccessor) error {
+				return state.Start(ctx)
 			}),
-			fx.OnStop(func(ctx context.Context,
-				breaker *modfraud.ServiceBreaker[*state.CoreAccessor, *header.ExtendedHeader],
-			) error {
-				return breaker.Stop(ctx)
+			fx.OnStop(func(ctx context.Context, state *state.CoreAccessor) error {
+				return state.Stop(ctx)
 			}),
 		)),
 		fxutil.ProvideIf(!coreCfg.IsEndpointConfigured(), func() (*state.CoreAccessor, Module) {