doc: add peer manager spec #4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
Wondertan,
gupadhyaya,
renaynay and
walldiss
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## shrex_spec #4609 +/- ##
=============================================
Coverage ? 36.03%
=============================================
Files ? 304
Lines ? 20170
Branches ? 0
=============================================
Hits ? 7268
Misses ? 11949
Partials ? 953 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vgonkivs
force-pushed
the
add_peer_manager_spec
branch
from
7ebba24 to
348ae33
Compare
renaynay
reviewed
Oct 6, 2025
Member
renaynay
left a comment
renaynay
left a comment
There was a problem hiding this comment.
just from a first read of the spec, I think it's too specific to implementation details of how our peer manager works.
We should provide just a basic spec for the skeleton of what this component is needed for / what it should do.
renaynay
reviewed
Oct 16, 2025
Member
renaynay
left a comment
renaynay
left a comment
There was a problem hiding this comment.
great changes, some comments re blacklisting.
A flowchart here would be very good addition
renaynay
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered