feat(store): Sync #287
Merged
feat(store): Sync #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
vgonkivs,
gupadhyaya,
walldiss and
cristaloleg
as code owners
Wondertan
force-pushed
the
store/flush
branch
3 times, most recently
from
2ef0f04 to
af22edd
Compare
renaynay
reviewed
May 12, 2025
| // and Store is not stopping(headers == nil) | ||
| if s.pending.Len() < s.Params.WriteBatchSize && headers != nil { | ||
| continue | ||
| return |
There was a problem hiding this comment.
Ah okay so you want to leave not large enough un-flushed batch in waiting and exit flush loop so that we aren't writing anything to disk for the Sync call, I see.
There was a problem hiding this comment.
This is why the method is not called Flush but Sync, which initially I called in Flush, but then realized that akcshually its not Flush
| // (2) Batching header writes | ||
| func (s *Store[H]) flushLoop() { | ||
| defer close(s.writesDn) | ||
| ctx := context.Background() |
There was a problem hiding this comment.
side note - we never cancel this ctx if we exit, should we put a cancellation in defer ?
There was a problem hiding this comment.
We can and even should if any internal calls spins up a backrground routine waiting on context, but as its not happening anywhere yet, it fine to keep as is
renaynay
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Sync method which ensures all pending writes are processed. It blocks until the operation completes or fails.
Also, the method gets used in
DeleteTo, ensuring deletion always operates on the latest state.This is technically a hack for until #241 and #263 come