fix: added cause of timeout for non test files #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldwin-sudo
requested review from
Wondertan,
gupadhyaya,
renaynay,
tzdybal,
vgonkivs and
walldiss
as code owners
Wondertan
reviewed
Jul 23, 2025
|
|
||
| // cap the max blocking time for the request call | ||
| ctx, cancel := context.WithTimeout(ctx, NetworkHeadRequestTimeout) | ||
| ctx, cancel := context.WithTimeoutCause(ctx, NetworkHeadRequestTimeout, errors.New("network head request time out ")) |
There was a problem hiding this comment.
Extract error to a global public var
| p.peerLk.RUnlock() | ||
|
|
||
| ctx, cancel := context.WithTimeout(ctx, time.Second*5) | ||
| ctx, cancel := context.WithTimeoutCause(ctx, time.Second*5, errors.New("dumping peers timeout ")) |
There was a problem hiding this comment.
To get the cause, it needs to be unwrapped via context.Cause. The context is used for the Put operation, so we should unwrap the cause in the log next to it.
| } | ||
|
|
||
| ctx, cancel := context.WithTimeout(serv.ctx, serv.Params.RequestTimeout) | ||
| ctx, cancel := context.WithTimeoutCause(serv.ctx, serv.Params.RequestTimeout, errors.New("server "+string(serv.host.ID())+": request timed out ")) |
There was a problem hiding this comment.
Similarly here, we need to unwrap the cause for this to have any effect.
|
alright , on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.WithTimeoutCause#312