Skip to content

Optimize advancing head #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Optimize advancing head #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb80a0b
perf: optimize advancing head and receding tail
KushnerykPavel Aug 7, 2025
bacb631
perf: optimize advancing head and receding tail
KushnerykPavel Aug 7, 2025
3893844
perf: optimize advancing head and receding tail
KushnerykPavel Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 65 additions & 29 deletions store/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,26 @@ func (s *Store[H]) recedeTail(ctx context.Context) {
}
}

// hasHeaderAt checks if a header exists at the given height by checking both pending headers and the height indexer.
func (s *Store[H]) hasHeaderAt(ctx context.Context, height uint64) bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this implementation into HasAt. The current implementation makes a risky assumption about everything being available between Tail and Head. While logic in go-header aims to have everything between Tail and Head available, it doesn't guarantee that to be the case at all times. Besides, the current HasAt doesn't check for headers outside of the Tail-Head range, which is an allowed case.

head, _ := s.Head(ctx)
if !head.IsZero() && head.Height() == height {
return true
}

tail, _ := s.Tail(ctx)
if !tail.IsZero() && tail.Height() == height {
return true
}

if h := s.pending.GetByHeight(height); !h.IsZero() {
return true
}

_, err := s.heightIndex.HashByHeight(ctx, height, false)
return err == nil
}

// nextHead finds the new contiguous Head by iterating the current Head up until the newer height Head is found.
// Returns true if the newer one was found.
func (s *Store[H]) nextHead(ctx context.Context) (head H, changed bool) {
Expand All @@ -639,25 +659,33 @@ func (s *Store[H]) nextHead(ctx context.Context) (head H, changed bool) {
ctx, done := s.withReadTransaction(ctx)
defer done()

debugLog := !changed && log.Level() == zapcore.DebugLevel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed is constant here

if debugLog {
startTime := time.Now()
log.Debugw("advancing head", "start_height", head.Height())
defer func() {
log.Debugw(
"finished advancing head",
"end_height",
head.Height(),
"took(s)",
time.Since(startTime),
)
}()
}

for ctx.Err() == nil {
h, err := s.getByHeight(ctx, head.Height()+1)
if err != nil {
log.Debugw("next head error", "current", head.Height(), "err", err)
nextHeight := head.Height() + 1

if !s.hasHeaderAt(ctx, nextHeight) {
log.Debugw("next head error", "current", head.Height(), "next_height", nextHeight)
return head, changed
}

if !changed && log.Level() == zapcore.DebugLevel {
now := time.Now()
log.Debugw("advancing head", "start_height", head.Height())
defer func() {
log.Debugw(
"finished advancing head",
"end_height",
head.Height(),
"took(s)",
time.Since(now),
)
}()
h, err := s.getByHeight(ctx, nextHeight)
if err != nil {
log.Debugw("next head error loading header", "current", head.Height(), "err", err)
return head, changed
}

head = h
Expand All @@ -679,24 +707,32 @@ func (s *Store[H]) nextTail(ctx context.Context) (tail H, changed bool) {
ctx, done := s.withReadTransaction(ctx)
defer done()

debugLog := !changed && log.Level() == zapcore.DebugLevel
if debugLog {
startTime := time.Now()
log.Debugw("receding tail", "start_height", tail.Height())
defer func() {
log.Debugw(
"finished receding tail",
"end_height",
tail.Height(),
"took(s)",
time.Since(startTime),
)
}()
}

for ctx.Err() == nil {
h, err := s.getByHeight(ctx, tail.Height()-1)
if err != nil {
prevHeight := tail.Height() - 1

if !s.hasHeaderAt(ctx, prevHeight) {
return tail, changed
}

if !changed && log.Level() == zapcore.DebugLevel {
now := time.Now()
log.Debugw("receding tail", "start_height", tail.Height())
defer func() {
log.Debugw(
"finished receding tail",
"end_height",
tail.Height(),
"took(s)",
time.Since(now),
)
}()
h, err := s.getByHeight(ctx, prevHeight)
if err != nil {
log.Debugw("next tail error loading header", "current", tail.Height(), "err", err)
return tail, changed
}

tail = h
Expand Down