fix(sync/metrics): fix blockTime metric #339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
gupadhyaya and
walldiss
as code owners
vgonkivs
force-pushed
the
fix_blockTime_metric
branch
from
d1a2d3d to
b6d0e13
Compare
vgonkivs
commented
Aug 28, 2025
| if !m.prevHeaderTs.IsZero() { | ||
| m.blockTime.Record(ctx, timestamp.Sub(m.prevHeaderTs).Seconds()) | ||
| } | ||
| m.prevHeaderTs = time.Now() |
There was a problem hiding this comment.
The reason for setting up a time.Now() as the original idea was to calculate how much time it takes to get the header through the network after it was produced.
Wondertan
reviewed
Aug 29, 2025
There was a problem hiding this comment.
hdr_sync_actual_blockTime_ts_histsomehow camelCase sneaked in- "duration between creation of 2 blocks" - metric description is confusing, I don't see why two blocks? From the code we seem to track the diff between the newly received header time and the time we got the last block, but no the timestamp and an actual time.Now when header was received.
This makes wonder if really need this metric? Like what do we get from knowing the time between of new block timestamp and last factual block receiving time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed BlockTime metric as it hasn't been pushed to otel before. Fixes #156