Modify get params to use api_key defined in params#85
Open
harshulsahni wants to merge 5 commits intoceliao:masterfrom
Open
Modify get params to use api_key defined in params#85harshulsahni wants to merge 5 commits intoceliao:masterfrom
harshulsahni wants to merge 5 commits intoceliao:masterfrom
Conversation
Add line to fix tests
…e into modify_get_params
harshulsahni
commented
Dec 25, 2021
| tmdb.API_KEY = None | ||
| with self.assertRaises(tmdb.base.APIKeyError): | ||
| tmdb_no_api_defined._get_params(params={}) | ||
| tmdb.API_KEY = API_KEY |
Author
There was a problem hiding this comment.
everytime I change the API_KEY to None, I "reset" it like so to preserve the other tests
Owner
|
@harshulsahni Why do you want to use more than one API Key? |
Author
|
@celiao I don't want to use more than one API key, but rather I would like the endpoint functions (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
_get_paramsfunction only relied ontmdb.API_KEY = ...to set an API key. This PR aims to add functionality so that the user can specify an API key in every function to eliminate this global dependency.See the test
test_tmdb_get_params_no_api_with_searchintest_base.pyfor example usage.Also, this PR simplifies some boolean and string logic to for conciseness.