specs(lockedGold): add pending timestamp precondition and reorder require in withdraw rule#11573
Open
Bashmunta wants to merge 1 commit intocelo-org:masterfrom
Open
specs(lockedGold): add pending timestamp precondition and reorder require in withdraw rule#11573Bashmunta wants to merge 1 commit intocelo-org:masterfrom
Bashmunta wants to merge 1 commit intocelo-org:masterfrom
Conversation
…uire in withdraw rule
Contributor
|
This PR is stale and will be closed in 30 days without activity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The withdraw rule could spuriously fail because it invoked withdraw without constraining time to or beyond the pending withdrawal’s availability, causing revert paths that invalidate the post-call balance equality assertion. This change declares getPendingWithdrawal in the methods block and updates the rule to read both the amount and its timestamp, then requires e.block.timestamp >= ts before invoking withdraw. It also moves the e.msg.sender != currentContract precondition before the call, so the environment is properly constrained. These adjustments mirror the contract’s own require for availability, focus the rule on the successful path the comment intends to model, and remove a source of non-deterministic failures without altering harnesses or contract code.