Skip to content

Add contribution demo file for GitHub workflow demonstration #11574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wearedood wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add contribution demo file for GitHub workflow demonstration #11574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192edd6
fix: use consistent timestamp for proposal and event (Issue #11481)
wearedood Nov 26, 2025
28558de
Add contribution demo file
wearedood Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTION_DEMO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Contribution Demo

This is a demonstration file created to show the GitHub contribution workflow.

## Changes Made
- Created this demo file
- Following the fork and pull request workflow

6 changes: 4 additions & 2 deletions packages/protocol/contracts/governance/Governance.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,7 +1203,9 @@ contract Governance is
proposal.deposit
);
// solhint-disable-next-line not-rely-on-time
proposal.timestamp = now;
uint256 currentTimestamp = now;
// solhint-disable-next-line not-rely-on-time
currentTimestamp.timestamp = now;
if (emptyIndices.length != 0) {
uint256 indexOfLastEmptyIndex = emptyIndices.length.sub(1);
dequeued[emptyIndices[indexOfLastEmptyIndex]] = proposalId;
Expand All @@ -1213,7 +1215,7 @@ contract Governance is
dequeued.push(proposalId);
}
// solhint-disable-next-line not-rely-on-time
emit ProposalDequeued(proposalId, now);
emit ProposalDequeued(proposalId, currentTimestamp);
wasAnyProposalDequeued = true;
}
if (wasAnyProposalDequeued) {
Expand Down