Backport upstream fix for v1.0.0 games backward compatability#111
Backport upstream fix for v1.0.0 games backward compatability#111
Conversation
… v1.0.0 games (succinctlabs#807) * fix(fault-proof): use l2BlockNumber() for backward compatibility with v1.0.0 games * fix: use l2BlockNumber in test monitor for v1.0.0 backward compat The PR missed one call site in the test utilities — the game monitor still called l2SequenceNumber() which doesn't exist on v1.0.0 contracts. Switch to l2BlockNumber() to match the other call sites. * ci: pin sp1up to v5.2.4 across all CI workflows and Dockerfiles SP1 v6 (rv64) was released and sp1up now defaults to v6. This project requires v5.2.4 (pinned in Cargo.toml and justfile). Add explicit `-v 5.2.4` flag to all 15 sp1up invocations across 5 CI workflows, 7 Dockerfiles, and the book documentation. --------- Co-authored-by: seolaoh <osa8361@gmail.com>
…mpat-l2-block-number
SP1 v6 (rv64) was released and sp1up now defaults to v6. This project requires v5.2.4 (pinned in Cargo.toml and justfile). Add explicit -v 5.2.4 flag to all remaining sp1up invocations.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 11. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
ezdac
left a comment
ezdac
left a comment
There was a problem hiding this comment.
Was accepted upstream and looks good to me!
| run: | | ||
| curl -L https://sp1.succinct.xyz | bash | ||
| ~/.sp1/bin/sp1up | ||
| ~/.sp1/bin/sp1up -v 5.2.4 |
There was a problem hiding this comment.
As a "fun-fact" I wasn't aware of since recently:
The sp1 installation here just installs the specific toolchain version, but the actual version used for elf
compilation has to be (and is) passed to the cargo-prove prove build --docker command with --tag 5.2.4 within the just build-elfs command.
That's because the --docker toolchain compilation will use the "deterministic" docker build and orchestrate downloading a docker image and handing off the build process to that docker container.
There was a problem hiding this comment.
I didn't know that, yeah the actual version running the SP1 program inside the docker container is pinned by --tag. Normally it works fine without sp1up version pinning, but I observed this elf CI failure a few days ago, and the root cause is sp1up is installed to the latest version v6.0.0 which switches the zkVM target from riscv32im to riscv64im. So the local toolchain v6.0.0 is telling the v5.2.4 docker container to compile for riscv64, it can't find the target. The best practice is to match the version of sp1up installation and the tag of cargo-prove. With this change, now the elf CI works fine 🙂
3 participants
Summary
l2BlockNumber()instead ofl2SequenceNumber()so the proposer works with v1.0.0 dispute games (where onlyl2BlockNumber()exists) during the upgrade ofOPSuccinctFaultDisputeGamev1.0.0 → v2.0.0.sp1upto v5.2.4 everywhere. SP1 v6 (rv64) was released andsp1upnow defaults to v6; this repo stays on v5.2.4 (as in Cargo.toml and justfile).Related