Merged
Conversation
Performance Comparison (ELF: eigenda-range-elf-embedded)Range 18912909~18912914
|
The `postgresql_embedded` crate has a race condition in its binary extraction: its lock mechanism uses `.create(true)` instead of `.create_new(true)`, so concurrent `setup()` calls can both attempt to extract to the shared installation dir, causing "Directory not empty" errors. A mutex around `setup()` ensures only one test extracts at a time while `start()` still runs in parallel.
seolaoh
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See celo-org/celo-kona#134
The second commit is only there to make the tests less flaky and can be skipped if we want to minimize the diff before the release.