Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit dbc173b

Browse files
mayurkale22mayurkale22
authored
Replace assert.deepEqual with assert.deepStrictEqual (#563)
1 parent 20e4cf0 commit dbc173b

File tree

27 files changed

+163
-157
lines changed

27 files changed

+163
-157
lines changed

‎packages/opencensus-core/test/test-binary-serializer.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,17 +59,17 @@ describe('Binary Format Serializer', () => {
5959
describe('serializeBinary', () => {
6060
it('should serialize empty tag map', () => {
6161
const binary = serializeBinary(emptyTagMap);
62-
assert.deepEqual(deserializeBinary(binary), emptyTagMap);
62+
assert.deepStrictEqual(deserializeBinary(binary), emptyTagMap);
6363
});
6464

6565
it('should serialize with one tag map', () => {
6666
const binary = serializeBinary(singleTagMap);
67-
assert.deepEqual(deserializeBinary(binary), singleTagMap);
67+
assert.deepStrictEqual(deserializeBinary(binary), singleTagMap);
6868
});
6969

7070
it('should serialize with multiple tag', () => {
7171
const binary = serializeBinary(multipleTagMap);
72-
assert.deepEqual(deserializeBinary(binary), multipleTagMap);
72+
assert.deepStrictEqual(deserializeBinary(binary), multipleTagMap);
7373
});
7474

7575
it('should throw an error when exceeds the max serialized size', () => {

‎packages/opencensus-core/test/test-derived-cumulative.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe('DerivedCumulative', () => {
7979
map.set('key1', 'value1');
8080

8181
let metric = instance.getMetric();
82-
assert.notEqual(metric, null);
82+
assert.notStrictEqual(metric, null);
8383
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
8484
assert.strictEqual(metric!.timeseries.length, 1);
8585
assert.deepStrictEqual(metric!.timeseries, [{
@@ -123,7 +123,7 @@ describe('DerivedCumulative', () => {
123123
const queue = new QueueManager();
124124
instance.createTimeSeries(LABEL_VALUES_200, queue);
125125
const metric = instance.getMetric();
126-
assert.notEqual(metric, null);
126+
assert.notStrictEqual(metric, null);
127127
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
128128
assert.strictEqual(metric!.timeseries.length, 1);
129129
assert.deepStrictEqual(metric!.timeseries, [{
@@ -150,7 +150,7 @@ describe('DerivedCumulative', () => {
150150
});
151151

152152
let metric = instance.getMetric();
153-
assert.notEqual(metric, null);
153+
assert.notStrictEqual(metric, null);
154154
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
155155
assert.strictEqual(metric!.timeseries.length, 1);
156156
assert.deepStrictEqual(metric!.timeseries, [{
@@ -180,7 +180,7 @@ describe('DerivedCumulative', () => {
180180
EMPTY_CONSTANT_LABELS, startime);
181181
doubleInstance.createTimeSeries(LABEL_VALUES_200, queue);
182182
const metric = doubleInstance.getMetric();
183-
assert.notEqual(metric, null);
183+
assert.notStrictEqual(metric, null);
184184
assert.deepStrictEqual(metric!.descriptor, {
185185
name: METRIC_NAME,
186186
description: METRIC_DESCRIPTION,
@@ -225,7 +225,7 @@ describe('DerivedCumulative', () => {
225225
instance.createTimeSeries(LABEL_VALUES_200, map);
226226
map.set('key', 'value');
227227
const metric = instance.getMetric();
228-
assert.notEqual(metric, null);
228+
assert.notStrictEqual(metric, null);
229229
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
230230
assert.strictEqual(metric!.timeseries.length, 1);
231231
assert.deepStrictEqual(metric!.timeseries, [{
@@ -247,7 +247,7 @@ describe('DerivedCumulative', () => {
247247
instance.createTimeSeries(LABEL_VALUES_200, arr);
248248
arr.push('test');
249249
let metric = instance.getMetric();
250-
assert.notEqual(metric, null);
250+
assert.notStrictEqual(metric, null);
251251
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
252252
instance.removeTimeSeries(LABEL_VALUES_200);
253253
metric = instance.getMetric();
@@ -269,7 +269,7 @@ describe('DerivedCumulative', () => {
269269
});
270270
arr.push('test');
271271
let metric = instance.getMetric();
272-
assert.notEqual(metric, null);
272+
assert.notStrictEqual(metric, null);
273273
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
274274
assert.strictEqual(metric!.timeseries.length, 2);
275275
instance.clear();

‎packages/opencensus-core/test/test-derived-gauge.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ describe('DerivedGauge', () => {
7777
map.set('key1', 'value1');
7878

7979
let metric = instance.getMetric();
80-
assert.notEqual(metric, null);
80+
assert.notStrictEqual(metric, null);
8181
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
8282
assert.strictEqual(metric!.timeseries.length, 1);
8383
assert.deepStrictEqual(
@@ -130,7 +130,7 @@ describe('DerivedGauge', () => {
130130
const obj = new QueueManager();
131131
instance.createTimeSeries(LABEL_VALUES_200, obj);
132132
const metric = instance.getMetric();
133-
assert.notEqual(metric, null);
133+
assert.notStrictEqual(metric, null);
134134
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
135135
assert.strictEqual(metric!.timeseries.length, 1);
136136
assert.deepStrictEqual(
@@ -161,7 +161,7 @@ describe('DerivedGauge', () => {
161161
});
162162

163163
let metric = instance.getMetric();
164-
assert.notEqual(metric, null);
164+
assert.notStrictEqual(metric, null);
165165
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
166166
assert.strictEqual(metric!.timeseries.length, 1);
167167
assert.deepStrictEqual(
@@ -199,7 +199,7 @@ describe('DerivedGauge', () => {
199199
EMPTY_CONSTANT_LABELS);
200200
doubleInstance.createTimeSeries(LABEL_VALUES_200, obj);
201201
const metric = doubleInstance.getMetric();
202-
assert.notEqual(metric, null);
202+
assert.notStrictEqual(metric, null);
203203
assert.deepStrictEqual(metric!.descriptor, {
204204
name: METRIC_NAME,
205205
description: METRIC_DESCRIPTION,
@@ -231,7 +231,7 @@ describe('DerivedGauge', () => {
231231
CONSTANT_LABELS);
232232
doubleInstance.createTimeSeries(LABEL_VALUES_200, obj);
233233
const metric = doubleInstance.getMetric();
234-
assert.notEqual(metric, null);
234+
assert.notStrictEqual(metric, null);
235235
assert.deepStrictEqual(metric!.descriptor, {
236236
name: METRIC_NAME,
237237
description: METRIC_DESCRIPTION,
@@ -257,7 +257,7 @@ describe('DerivedGauge', () => {
257257
instance.createTimeSeries(LABEL_VALUES_200, map);
258258
map.set('key', 'value');
259259
const metric = instance.getMetric();
260-
assert.notEqual(metric, null);
260+
assert.notStrictEqual(metric, null);
261261
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
262262
assert.strictEqual(metric!.timeseries.length, 1);
263263
assert.deepStrictEqual(
@@ -282,7 +282,7 @@ describe('DerivedGauge', () => {
282282
instance.createTimeSeries(LABEL_VALUES_200, arr);
283283
arr.push('test');
284284
let metric = instance.getMetric();
285-
assert.notEqual(metric, null);
285+
assert.notStrictEqual(metric, null);
286286
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
287287
instance.removeTimeSeries(LABEL_VALUES_200);
288288
metric = instance.getMetric();
@@ -303,7 +303,7 @@ describe('DerivedGauge', () => {
303303
});
304304
arr.push('test');
305305
let metric = instance.getMetric();
306-
assert.notEqual(metric, null);
306+
assert.notStrictEqual(metric, null);
307307
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
308308
assert.strictEqual(metric!.timeseries.length, 2);
309309
instance.clear();

‎packages/opencensus-core/test/test-gauge.ts‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe('GAUGE_INT64', () => {
7979
point.add(10);
8080

8181
let metric = instance.getMetric();
82-
assert.notEqual(metric, null);
82+
assert.notStrictEqual(metric, null);
8383
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
8484
assert.strictEqual(metric!.timeseries.length, 1);
8585
assert.deepStrictEqual(
@@ -122,7 +122,7 @@ describe('GAUGE_INT64', () => {
122122
const point = instance.getOrCreateTimeSeries(LABEL_VALUES_200);
123123
point.add(10);
124124
let metric = instance.getMetric();
125-
assert.notEqual(metric, null);
125+
assert.notStrictEqual(metric, null);
126126
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
127127
assert.strictEqual(metric!.timeseries.length, 1);
128128
assert.deepStrictEqual(
@@ -156,7 +156,7 @@ describe('GAUGE_INT64', () => {
156156
const point = instance.getDefaultTimeSeries();
157157
point.add(10);
158158
const metric = instance.getMetric();
159-
assert.notEqual(metric, null);
159+
assert.notStrictEqual(metric, null);
160160
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
161161
assert.strictEqual(metric!.timeseries.length, 1);
162162
assert.deepStrictEqual(
@@ -220,7 +220,7 @@ describe('GAUGE_INT64', () => {
220220
const point = instance.getDefaultTimeSeries();
221221
point.add(200);
222222
const metric = instance.getMetric();
223-
assert.notEqual(metric, null);
223+
assert.notStrictEqual(metric, null);
224224
assert.deepStrictEqual(metric!.descriptor.labelKeys.length, 3);
225225
assert.deepStrictEqual(metric!.descriptor.type, 1);
226226
assert.strictEqual(metric!.timeseries.length, 1);
@@ -239,7 +239,7 @@ describe('GAUGE_INT64', () => {
239239
const point = instance.getDefaultTimeSeries();
240240
point.add(300);
241241
let metric = instance.getMetric();
242-
assert.notEqual(metric, null);
242+
assert.notStrictEqual(metric, null);
243243
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
244244
assert.strictEqual(metric!.timeseries.length, 1);
245245
assert.deepStrictEqual(
@@ -255,7 +255,7 @@ describe('GAUGE_INT64', () => {
255255
const point1 = instance.getDefaultTimeSeries();
256256
point1.add(400);
257257
metric = instance.getMetric();
258-
assert.notEqual(metric, null);
258+
assert.notStrictEqual(metric, null);
259259
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
260260
assert.strictEqual(metric!.timeseries.length, 1);
261261
assert.deepStrictEqual(
@@ -274,7 +274,7 @@ describe('GAUGE_INT64', () => {
274274
const point = instance.getOrCreateTimeSeries(LABEL_VALUES_200);
275275
point.add(10);
276276
let metric = instance.getMetric();
277-
assert.notEqual(metric, null);
277+
assert.notStrictEqual(metric, null);
278278
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
279279
instance.removeTimeSeries(LABEL_VALUES_200);
280280
metric = instance.getMetric();
@@ -288,7 +288,7 @@ describe('GAUGE_INT64', () => {
288288
const point1 = instance.getOrCreateTimeSeries(LABEL_VALUES_400);
289289
point1.add(10);
290290
let metric = instance.getMetric();
291-
assert.notEqual(metric, null);
291+
assert.notStrictEqual(metric, null);
292292
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
293293
assert.strictEqual(metric!.timeseries.length, 2);
294294
instance.clear();
@@ -341,7 +341,7 @@ describe('GAUGE_DOUBLE', () => {
341341
point.add(10.34);
342342

343343
let metric = instance.getMetric();
344-
assert.notEqual(metric, null);
344+
assert.notStrictEqual(metric, null);
345345
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
346346
assert.strictEqual(metric!.timeseries.length, 1);
347347
assert.deepStrictEqual(metric!.timeseries, [
@@ -382,7 +382,7 @@ describe('GAUGE_DOUBLE', () => {
382382
const point = instance.getOrCreateTimeSeries(LABEL_VALUES_200);
383383
point.add(12.1);
384384
let metric = instance.getMetric();
385-
assert.notEqual(metric, null);
385+
assert.notStrictEqual(metric, null);
386386
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
387387
assert.strictEqual(metric!.timeseries.length, 1);
388388
assert.deepStrictEqual(metric!.timeseries, [
@@ -416,7 +416,7 @@ describe('GAUGE_DOUBLE', () => {
416416
const point = instance.getDefaultTimeSeries();
417417
point.add(10.1);
418418
const metric = instance.getMetric();
419-
assert.notEqual(metric, null);
419+
assert.notStrictEqual(metric, null);
420420
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
421421
assert.strictEqual(metric!.timeseries.length, 1);
422422
assert.deepStrictEqual(metric!.timeseries, [
@@ -433,7 +433,7 @@ describe('GAUGE_DOUBLE', () => {
433433
const point = instance.getDefaultTimeSeries();
434434
point.add(300.1);
435435
let metric = instance.getMetric();
436-
assert.notEqual(metric, null);
436+
assert.notStrictEqual(metric, null);
437437
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
438438
assert.strictEqual(metric!.timeseries.length, 1);
439439
assert.deepStrictEqual(metric!.timeseries, [
@@ -449,7 +449,7 @@ describe('GAUGE_DOUBLE', () => {
449449
const point1 = instance.getDefaultTimeSeries();
450450
point1.add(400.1);
451451
metric = instance.getMetric();
452-
assert.notEqual(metric, null);
452+
assert.notStrictEqual(metric, null);
453453
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
454454
assert.strictEqual(metric!.timeseries.length, 1);
455455
assert.deepStrictEqual(metric!.timeseries, [
@@ -473,7 +473,7 @@ describe('GAUGE_DOUBLE', () => {
473473
const point = instance.getDefaultTimeSeries();
474474
point.add(10.1);
475475
const metric = instance.getMetric();
476-
assert.notEqual(metric, null);
476+
assert.notStrictEqual(metric, null);
477477
assert.deepStrictEqual(metric!.descriptor.labelKeys.length, 3);
478478
assert.deepStrictEqual(metric!.descriptor.type, 2);
479479
assert.strictEqual(metric!.timeseries.length, 1);
@@ -494,7 +494,7 @@ describe('GAUGE_DOUBLE', () => {
494494
const point = instance.getOrCreateTimeSeries(LABEL_VALUES_200);
495495
point.add(10.23);
496496
let metric = instance.getMetric();
497-
assert.notEqual(metric, null);
497+
assert.notStrictEqual(metric, null);
498498
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
499499
instance.removeTimeSeries(LABEL_VALUES_200);
500500
metric = instance.getMetric();
@@ -508,7 +508,7 @@ describe('GAUGE_DOUBLE', () => {
508508
const point1 = instance.getOrCreateTimeSeries(LABEL_VALUES_400);
509509
point1.add(15.2);
510510
let metric = instance.getMetric();
511-
assert.notEqual(metric, null);
511+
assert.notStrictEqual(metric, null);
512512
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
513513
assert.strictEqual(metric!.timeseries.length, 2);
514514
instance.clear();

‎packages/opencensus-core/test/test-metric-producer-manager.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ describe('MetricProducerManager()', () => {
3434
const metricProducerList =
3535
metricProducerManagerInstance.getAllMetricProducer();
3636

37-
assert.notDeepEqual(metricProducerList, null);
37+
assert.notStrictEqual(metricProducerList, null);
3838
assert.strictEqual(metricProducerList.size, 1);
3939
});
4040

‎packages/opencensus-core/test/test-resource.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('Resource()', () => {
4343

4444
assert.strictEqual(resource.type, 'k8s.io/container');
4545
assert.strictEqual(Object.keys(actualLabels).length, 3);
46-
assert.deepEqual(actualLabels, expectedLabels);
46+
assert.deepStrictEqual(actualLabels, expectedLabels);
4747
});
4848
});
4949

@@ -61,7 +61,7 @@ describe('mergeResources()', () => {
6161

6262
assert.strictEqual(resource.type, 't1');
6363
assert.strictEqual(Object.keys(resource.labels).length, 2);
64-
assert.deepEqual(resource.labels, expectedLabels);
64+
assert.deepStrictEqual(resource.labels, expectedLabels);
6565
});
6666

6767
it('merge resources with default, resource1, resource2 = empty', () => {
@@ -72,7 +72,7 @@ describe('mergeResources()', () => {
7272

7373
assert.strictEqual(resource.type, 't1');
7474
assert.strictEqual(Object.keys(resource.labels).length, 2);
75-
assert.deepEqual(resource.labels, expectedLabels);
75+
assert.deepStrictEqual(resource.labels, expectedLabels);
7676
});
7777

7878
it('merge resources with default, resource1 = empty, resource2', () => {
@@ -83,7 +83,7 @@ describe('mergeResources()', () => {
8383

8484
assert.strictEqual(resource.type, 't2');
8585
assert.strictEqual(Object.keys(resource.labels).length, 3);
86-
assert.deepEqual(resource.labels, expectedLabels);
86+
assert.deepStrictEqual(resource.labels, expectedLabels);
8787
});
8888

8989
it('merge resources with default1, resource1, resource2', () => {
@@ -93,6 +93,6 @@ describe('mergeResources()', () => {
9393

9494
assert.strictEqual(resource.type, 'default');
9595
assert.strictEqual(Object.keys(resource.labels).length, 3);
96-
assert.deepEqual(resource.labels, expectedLabels);
96+
assert.deepStrictEqual(resource.labels, expectedLabels);
9797
});
9898
});

‎packages/opencensus-core/test/test-root-span.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ describe('RootSpan', () => {
276276
assert.strictEqual(rootSpan.droppedAnnotationsCount, 0);
277277
assert.strictEqual(
278278
rootSpan.annotations[0].description, 'description test');
279-
assert.deepEqual(rootSpan.annotations[0].attributes, {});
279+
assert.deepStrictEqual(rootSpan.annotations[0].attributes, {});
280280
assert.ok(rootSpan.annotations[0].timestamp > 0);
281281
});
282282
});

‎packages/opencensus-core/test/test-span.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -317,13 +317,13 @@ describe('Span', () => {
317317
/** compressedSize */ 40);
318318

319319
assert.ok(span.messageEvents.length > 0);
320-
assert.deepEqual(span.messageEvents, [{
321-
type: types.MessageEventType.UNSPECIFIED,
322-
id: 1,
323-
timestamp: 1550000000000,
324-
uncompressedSize: 55,
325-
compressedSize: 40,
326-
}]);
320+
assert.deepStrictEqual(span.messageEvents, [{
321+
type: types.MessageEventType.UNSPECIFIED,
322+
id: 1,
323+
timestamp: 1550000000000,
324+
uncompressedSize: 55,
325+
compressedSize: 40,
326+
}]);
327327
assert.strictEqual(span.droppedMessageEventsCount, 0);
328328
assert.ok(instanceOfLink(span.messageEvents[0]));
329329
});

0 commit comments

Comments
 (0)