Loosen ikey validation to follow GUID (#986)

Author: lzchen

contrib/opencensus-ext-azure/CHANGELOG.md

@@ -14,6 +14,8 @@
   ([#949](https://github.com/census-instrumentation/opencensus-python/pull/949))
 - Disable heartbeat metrics in exporters
   ([#984](https://github.com/census-instrumentation/opencensus-python/pull/984))
+- Loosen instrumentation key validation to GUID
+  ([#984](https://github.com/census-instrumentation/opencensus-python/pull/984))
 
 ## 1.0.4
 Released 2020-06-29

contrib/opencensus-ext-azure/opencensus/ext/azure/common/transport.py

@@ -76,7 +76,6 @@ def _transmit(self, envelopes):
             except Exception:
                 pass
         if response.status_code == 200:
-            logger.info('Transmission succeeded: %s.', text)
             return 0
         if response.status_code == 206:  # Partial Content
             if data:

contrib/opencensus-ext-azure/opencensus/ext/azure/common/utils.py

@@ -58,12 +58,9 @@ def timestamp_to_iso_str(timestamp):
     return to_iso_str(datetime.datetime.utcfromtimestamp(timestamp))
 
 
-# Validate UUID format
-# Specs taken from https://tools.ietf.org/html/rfc4122
+# Validate GUID format
 uuid_regex_pattern = re.compile('^[0-9a-f]{8}-'
-                                '[0-9a-f]{4}-'
-                                '[1-5][0-9a-f]{3}-'
-                                '[89ab][0-9a-f]{3}-'
+                                '([0-9a-f]{4}-){3}'
                                 '[0-9a-f]{12}$')
 
 

contrib/opencensus-ext-azure/tests/test_azure_utils.py

@@ -121,12 +121,14 @@ def test_invalid_key_section5_hex(self):
         self.assertRaises(ValueError,
                           lambda: utils.validate_instrumentation_key(key))
 
-    def test_invalid_key_version(self):
-        key = '1234abcd-5678-6efa-8abc-1234567890ab'
-        self.assertRaises(ValueError,
-                          lambda: utils.validate_instrumentation_key(key))
+    def test_valid_key_section2_hex(self):
+        key = '1234abcd-567a-4efa-8abc-1234567890ab'
+        self.assertIsNone(utils.validate_instrumentation_key(key))
 
-    def test_invalid_key_variant(self):
-        key = '1234abcd-5678-4efa-2abc-1234567890ab'
-        self.assertRaises(ValueError,
-                          lambda: utils.validate_instrumentation_key(key))
+    def test_valid_key_section3_hex(self):
+        key = '1234abcd-5678-befa-8abc-1234567890ab'
+        self.assertIsNone(utils.validate_instrumentation_key(key))
+
+    def test_valid_key_section4_hex(self):
+        key = '1234abcd-5678-4efa-cabc-1234567890ab'
+        self.assertIsNone(utils.validate_instrumentation_key(key))