Closed
Conversation
Implements an advanced search method: - Hybrid Search: RRF fusion of semantic and FTS5 keyword search - semantic search works with article_embeddings_e5 index - FTS5 search works with fts_article_embeddings_e5 index Features: - New API endpoint(hybrid_search) is added for the search method - New method in search_knowledge_base
Implements an advanced search method: - Hybrid Search: RRF fusion of semantic and FTS5 keyword search - semantic search works with article_embeddings_e5 index - FTS5 search works with fts_article_embeddings_e5 index Features: - New API endpoint(hybrid_search) is added for the search method - New method in search_knowledge_base
Corrected the search method from 'hybrid_hyde_search' to 'hybrid_search'.
Implements an advanced search method: - Hybrid Search: RRF fusion of semantic and FTS5 keyword search - semantic search works with article_embeddings_e5 index - FTS5 search works with fts_article_embeddings_e5 index Features: - New API endpoint(hybrid_search) is added for the search method - New method in search_knowledge_base
Closed
Removed unused search methods from the search function.
Enniwhere
requested changes
Jan 8, 2026
Contributor
Enniwhere
left a comment
Enniwhere
left a comment
There was a problem hiding this comment.
I only have a very small change requested: Make new workflows instead of changing the existing ones.
Contributor
There was a problem hiding this comment.
We should avoid changing the existing workflows and rather make new ones, even if it means having more duplicate code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements an advanced search method:
Hybrid Search: RRF fusion of semantic and FTS5 keyword search
semantic search works with article_embeddings_e5 index
FTS5 search works with fts_article_embeddings_e5 index
Features:
New API endpoint(hybrid_search) is added for the search method
New method in search_knowledge_base
Test:
run the beta_workflow_v1_large as given below to verify the hybrid_search method:
curl -X POST http://localhost:8001/workflows/beta_workflow_v1_large/run
-H "Content-Type: application/json"
-d '{
"user_input": "Hvad er Aasiaat og hvad er byens vigtigste erhverv?",
"conversation_id": "tc6-19n",
"conversation_history": []
}'