Skip to content

Ctor 1320 enhance sc prometheus gateway apiv1 to prometheus gateway events apiv2 and prometheus gateway metrics apiv2 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
omercier wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Ctor 1320 enhance sc prometheus gateway apiv1 to prometheus gateway events apiv2 and prometheus gateway metrics apiv2 #279

omercier wants to merge 27 commits into from

Conversation

@omercier
Copy link
Contributor

@omercier omercier commented Apr 29, 2025

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID (for centreon-internal)

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • 24.10.x
  • master

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

tanguyvda
tanguyvda requested changes May 12, 2025
View reviewed changes
tanguyvda
tanguyvda requested changes May 13, 2025
View reviewed changes
Copy link
Contributor

@tanguyvda tanguyvda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back in the days, I've made a lot of camelCase syntaxes. Need to switch them to snake_case

@omercier

This comment was marked as resolved.

Sign in to view
@omercier omercier requested a review from tanguyvda May 22, 2025 16:16
@omercier omercier marked this pull request as ready for review May 22, 2025 16:16
@omercier omercier requested a review from a team as a code owner May 22, 2025 16:16
@omercier omercier requested a review from sdepassio May 26, 2025 11:30
omercier and others added 23 commits June 27, 2025 17:27
@omercier
wip: things to improve?
532cd6d
@omercier
feat(prometheus-metrics-v2): new connector for metrics
c153bbf
@omercier
fix CTOR-1626
107b0d7
@omercier
enh(libs): log an error when log_level is ignored because of its type
06a7303
@omercier
feat(prometheus-events-v2): new connector for events
232b312
@omercier @tanguyvda
force max_buffer_size to 1 because we each service is sent to its own…
1bd9e40 
… url

Co-authored-by: tcharles <[email protected]>
@omercier @tanguyvda
convert httpResponseBody to string before logging it
f8f6478 
Co-authored-by: tcharles <[email protected]>
@omercier @tanguyvda
remove useless __internal_ts_last_flush update
60a38cf 
Co-authored-by: tcharles <[email protected]>
@omercier
enh(lib): use mime.b64
1c5fe2d
@omercier
enh: move formatting of payload where it belongs
e888de0
@omercier @tanguyvda
Apply suggestions from code review by Tanguy
19fb8ae 
Co-authored-by: tcharles <[email protected]>
@omercier
fix: default value for log_level was empty string instead of number
05ecaf9
@omercier
end: use existing generic parameters to format metrics instead of har…
5b15944 
…d coded
@omercier
enh: handle enable_extended_metric_name param
05129e0
@omercier
enh: add log_curl_command and send_data debug
dcef3bd
@omercier
enh: various enhancements
ae1c304 
- metrics naming looks ok: no unit redundancy in names
- instances and subinstances handled
- removed hosts events since theyre not relevant
- the headers were not displayed by log_curl_command
@omercier
fix: fixed some silly mistakes
ae7fc3d
@omercier
enh: partially convert camelCase to snake_case
0d1bc30
@omercier
finish removing camelCase
73ffa4b
@omercier
enh: improve self-documentation
d1c1e27
@omercier
fix: handle host names with special characters + other
7ad413e 
- rename url parameter to match specs
- enable smart sleep for events too
- rewrite end of write() function
@omercier
enh: add get_hostgroup_alias
88489ff
@omercier
enh sc_broker documentation
ac4f091
@omercier omercier force-pushed the CTOR-1320-Enhance-sc-prometheus-gateway-apiv1-to-prometheus-gateway-events-apiv2-and-prometheus-gateway-metrics-apiv2 branch from c45dc0d to dad573e Compare June 27, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanguyvda tanguyvda Awaiting requested review from tanguyvda

@sdepassio sdepassio Awaiting requested review from sdepassio

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omercier @tanguyvda