Conversation
|
|
||
| type JW3THeader struct { | ||
| Algorithm string `json:"algorithm"` | ||
| AddressType string `json:"address-type"` |
There was a problem hiding this comment.
nit - for the other types that we expose, we use underscores instead of dashes. Maybe we can do that here to keep things consistent?
There was a problem hiding this comment.
I would agree, I am just following the community proposed standard https://hackmd.io/Xp1-M5WVRFybdLwjWqXdEw?view#Web3-Authentication-Design-Draft and that is using - instead.
There was a problem hiding this comment.
indeed it was meant to be underscore. The TOML format was set to underscore but it was not updated for the JSON format. It is fixed in the doc.
There was a problem hiding this comment.
@hamidra thanks for the input we will update to _ then
http/auth/service.go
Outdated
| func decodeJW3T(jw3t string) (*JW3THeader, *JW3TPayload, []byte, error) { | ||
| fragments := strings.Split(jw3t, ".") | ||
| if len(fragments) != 3 { | ||
| return nil, nil, nil, errors.New("bad JW3T format") |
There was a problem hiding this comment.
I suggest we use constant errors for cases like these.
There was a problem hiding this comment.
yep, sounds good
http/auth/service.go
Outdated
| ProxyType string | ||
| } | ||
|
|
||
| type Auth struct { |
There was a problem hiding this comment.
Can we have an interface for this so we can use mocks in the tests?
There was a problem hiding this comment.
Indeed, will do that
http/auth/service.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| key, err := types.CreateStorageKey(meta, identity.ProxyPallet, identity.ProxiesMethod, proxyPublicKey) |
There was a problem hiding this comment.
We can move all this proxy stuff in a separate service that deals with this. I created one on my identities branch, for now I only implemented this:
type API interface {
GetProxies(ctx context.Context, accountID *types.AccountID) (*types.ProxyStorageEntry, error)
}
Lemme know how you want to proceed.
There was a problem hiding this comment.
For certain we will do that, since you were working on the proxies interaction, I didnt want to step on each other toes. I was going to do add that as part of your interface once it was in.
mikiquantum
left a comment
mikiquantum
left a comment
There was a problem hiding this comment.
@cdamian thanks for the review, If you have any suggestions on the admin/nonadmin or any other code structure approach overall would be great to hear.
Let sync on how to best integrate your work items and this one as seamlessly as possible.
|
|
||
| type JW3THeader struct { | ||
| Algorithm string `json:"algorithm"` | ||
| AddressType string `json:"address-type"` |
There was a problem hiding this comment.
I would agree, I am just following the community proposed standard https://hackmd.io/Xp1-M5WVRFybdLwjWqXdEw?view#Web3-Authentication-Design-Draft and that is using - instead.
http/auth/service.go
Outdated
| ProxyType string | ||
| } | ||
|
|
||
| type Auth struct { |
There was a problem hiding this comment.
Indeed, will do that
http/auth/service.go
Outdated
| func decodeJW3T(jw3t string) (*JW3THeader, *JW3TPayload, []byte, error) { | ||
| fragments := strings.Split(jw3t, ".") | ||
| if len(fragments) != 3 { | ||
| return nil, nil, nil, errors.New("bad JW3T format") |
There was a problem hiding this comment.
yep, sounds good
http/auth/service.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| key, err := types.CreateStorageKey(meta, identity.ProxyPallet, identity.ProxiesMethod, proxyPublicKey) |
There was a problem hiding this comment.
For certain we will do that, since you were working on the proxies interaction, I didnt want to step on each other toes. I was going to do add that as part of your interface once it was in.
3 participants
No description provided.