Invariants: Investigate & fix outstanding critical & potential issues#599
Merged
nican0r merged 63 commits intoinvariants_rebase-main-5fcfc44781ded1908c613d341fc5de066554dd58from Oct 3, 2025
Conversation
|
Coverage after merging invariants_potential-issues into invariants_rebase-main-5fcfc44781ded1908c613d341fc5de066554dd58 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sherlock AI FindingsThe automated tool identified the following potential security issues in the codebase. Please review the details for each issue in the linked dashboard.
Next Steps: Review the linked issues in the dashboard and address high-severity bugs first. Contact the team if you need assistance. Full report available at: https://ai.sherlock.xyz/runs/8dfe06e7-6177-4870-8b98-49344494dfc9 |
nican0r
merged commit 519653a
into
invariants_rebase-main-5fcfc44781ded1908c613d341fc5de066554dd58
2 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed all outstanding critical and potential issues from #468, June 2025 (pre final v3 audits). Based against intermediary #598 to reduce
main-rebase noise. Note: There might be new issues emerging from running the suite due to the heavy amount of changes and rebases.Invariant Test Improvements
Zero Price Edge Case Handling
Async Vault Properties
maxDepositandmaxWithdrawproperty calculationsmaxMintproperty for async vaultsInfrastructure Improvements
MessageProcessorandMessageDispatcherin favor of real implementationsspoke.vaultToAssetId()instead of hardcoded pool currencyCode Cleanup
root_{cancel, schedule}RelyfunctionTODO