feat: Isolated Adapter Cross-Chain Tests by wischli · Pull Request #775 · centrifuge/protocol

wischli · 2026-02-10T16:20:31Z

Updated port from https://github.com/centrifuge/protocol-internal/pull/119

Extends (and supersedes) #767 and replaces cross-chain tests created there with isolated pool adapter tests. In #767, the main goal was first to ensure cross-chain messages were working. However, the setup there involved an unhappy UX because

the unbatched messages often failed due to race-condition (i.e. NotifyShareClass before NotifyPool)
the setup theoretically prepared for an invest flow but in practice was too cumbersome to get anything out of it other succeeded messages from hub to spoke and vice versa (ref)

Please note the changelog description includes also changes from #767 done by @gpmayorga

Per @gpmayorga 's request, no deployment changes from his branch were touched:

  ┌───────────────────────────────┬───────────────────────────────┬───────────────────────────┐
  │             File              │             PR #767           │        This PR            │
  ├───────────────────────────────┼───────────────────────────────┼───────────────────────────┤
  │ env/*.json contracts          │ null blockNumber/txHash       │ Actual values ✅          │
  ├───────────────────────────────┼───────────────────────────────┼───────────────────────────┤
  │ env/*.json adapters.threshold │ Missing (outdated)            │ 2 ✅                      │
  ├───────────────────────────────┼───────────────────────────────┼───────────────────────────┤
  │ verifier.py                   │ Simple receipts-only parsing  │ CREATE3/factory-aware ✅  │
  ├───────────────────────────────┼───────────────────────────────┼───────────────────────────┤
  │ load_config.py                │ Direct private key assignment │ Mainnet/testnet safety ✅ │
  ├───────────────────────────────┼───────────────────────────────┼───────────────────────────┤
  │ deploy.py                     │ Identical                     │ Identical                 │
  ├───────────────────────────────┼───────────────────────────────┼───────────────────────────┤
  │ runner.py                     │ Identical                     │ Identical                 │
  └───────────────────────────────┴───────────────────────────────┴───────────────────────────┘

Product requirements

Consolidate testnet cross-chain adapter testing into a single script (TestAdapterIsolation.s.sol) that supports all four adapters (Axelar, LayerZero, Wormhole, Chainlink) with a cost-efficient three-phase workflow
Replace the old two-script approach (TestCrossChainHub + TestCrossChainSpoke) with a unified script that separates pool creation, adapter configuration, and repeatable share class testing
Improve deployment automation: deploy all testnets in a single CI run, support dry-run for PRs, add automatic contract verification for factory-deployed contracts
Disable Wormhole adapter deployment on testnets (sepolia) and mainnet chains (Avalanche, BNB) as part of deprecation
Update adapter wiring to handle asymmetric configurations where not all adapters are deployed on every chain

Design notes

TestAdapterIsolation.s.sol uses a three-phase design: Phase 1 creates pools (hub-only, no XC), Phase 2 configures isolated adapters (2 XC messages each), Phase 3 sends NotifyShareClass (repeatable without re-running setup). This replaces the previous approach that required full re-setup for each test round
BaseTestData.s.sol was refactored to load adapter contract references (Axelar, LayerZero, Wormhole, Chainlink) from config JSON, enabling per-pool adapter isolation via hub.setAdapters()
WireAdapters.s.sol now checks the deploy flag in destination network config before wiring, preventing InvalidAdapter errors from asymmetric adapter configurations
The deploy CI workflow (deploy.yml) was simplified from per-network manual dispatch to a single deploy:testnets command that handles all testnet deployments sequentially with optional dry-run
deploy.py gained deploy:testnets and crosschaintest:hub/crosschaintest:spoke steps, plus automatic factory contract verification via verify:contracts
Wormhole deploy flag set to false in sepolia.json, avalanche.json, and bnb-smart-chain.json. Wormhole is being deprecated. Scanner URLs updated with direct filtered links
Pool index scheme: one pool per adapter at GAS_TEST_BASE + adapterIndex (default 91000). Chainlink support added (index 3) with single-message phases to stay under CCIP's per-message gas limit

…management

- Updated argument validation to support new deployment steps and improved error handling. - Enhanced wiring logic for adapters, including support for multiple connected networks.

…nventions - Changed backward compatibility check in deploy.py from "release:sepolia" to "deploy:testnets". - Updated contract names in crosschain.py to use lowercase for consistency. - Added logic in WireAdapters.s.sol to skip deployment if the deploy flag is set to false.

- Updated deployment step names from "deploy:testnets" to "deploy:all" for consistency. - Changed references from "deploy:protocol" to "deploy:full" to align with new deployment structure. - Adjusted user prompts and validation messages to reflect the updated command usage. - Ensured backward compatibility for the new deployment step naming.

- Updated deployment step from "deploy:all" to "deploy:testnets" for clarity and consistency. - Implemented dry-run mode to skip verification and state saving during test deployments.

- Added early network validation in load_config.py to prevent loading .env values if a network mismatch is detected. - Updated deploy.py to normalize the step for the special case of deploying to testnets. - Improved runner.py to skip verification in dry-run mode with appropriate messaging.

* base implementation impl almost complete add BRM and split in two spells protect calls migrate PoolEscrow organize spell draft next steps add script and test structure more correct setup minor changes minor changes more dubugging process move validationf files to validation folder fix fixes fix version deployment changes working preview address remove check parameterize deployer address in Deployer contract use registerPool remove manual process to ensure no outstanding orders test passing but without indexing data retrieve the hubPools from indexer more indexer data and fixes * fix subsidizing issue * correct refunding * correct refunding assuming no escrow used in spoke side * fixes and more support * onOfframp indexer requests * link vaults correctly and fix bs managers * filtered assets and centrifugeIds * fix imports * correclty process for unexisting poolIds in that chain * fix asset treatment * fix import * tested for all chains working * add spell lock post-check * discard all spell test from CI * fix spelling * minor changes from review * fix spelling * fix coverage * fix anvil

* testnet support * Add patch to suppor the non-existence of freelyTransferibleHook in testnets * migration fixes * custom pools by input * add pool for testnet Signed-off-by: lemunozm <lemunozm@gmail.com> * fix spelling --------- Signed-off-by: lemunozm <lemunozm@gmail.com>

* rely steps for root in migration * add deployer for the migration * deploy with blocked registerAsset and fix it in the spell * simplify migration script * unify migration spells into just one * disable spell * fix imports * apply comments

wischli · 2026-02-10T16:47:00Z

@gpmayorga When you have the time, please take a look if I truly included all of your desired changes from #767 and didn't flush them, especially in 9beffab where I removed any changed to env files because I believe these were outdated at this point.

Also @lemunozm please take a look at all deployment related changes. I am not fully synced on the details from the recent changes in the last weeks. All I wanted to achieve here is better cross chain adapter tests on top of #767.

lemunozm

Well done with the AdapterIsolation script! Nice to have it. Just some minor comments.

Also @lemunozm please take a look at all deployment related changes. I am not fully synced on the details from the recent changes in the last weeks. All I wanted to achieve here is better cross chain adapter tests on top of #767.

I think everything is good. You probably will have a small git conflict in anvil.py when rebasing. Now the generated evn json file must have a baseRpcUrl

lemunozm · 2026-02-12T11:17:41Z

script/testnet/README.md

+### Contract Addresses (Same on All Chains via CREATE3)
+
+```bash
+export ROOT=0x8a7c1D479Cc77a5458F74C480B9b306BB29b953e
+export MULTI_ADAPTER=0x2C61BC7C5aF7f0Af2888dE9343C3ce4b2fBf5933
+export HUB=0xE5e49CEdB5D3DCD24b25e2886a0c5E27e2e9CBe9
+export HUB_REGISTRY=0x92e78c7680303b04e4CE9d1736c000288e2339E5
+export VAULT_REGISTRY=0x22dB7862f9D903F49CF179C7079E72739f5a3c1D
+export SPOKE=0x7Ac5B65764A8b1A19E832FdE942ce618EeF823aF
+
+# Adapters
+export AXELAR_ADAPTER=0xb324e55F8332748142274FC76De0A8D95d453Ada
+export LAYERZERO_ADAPTER=0x24f3192d46869609F8F6605e662b8146CA4240d3
+export WORMHOLE_ADAPTER=0x5940ad8841C50a57F0464f36BaF488964E86655e


These are no longer valid because we redeployed in testnet with fresh addreses

lemunozm · 2026-02-12T11:19:21Z

script/testnet/README.md

+
+---
+
+## Step 0: Register Asset (One-Time Setup)


NIT (and maybe not for now). Wondering if all these steps can be added to a .sh file instead 🤔

gpmayorga · 2026-02-12T12:43:26Z

The deployment is broken for some reason (see CI checks). I will be able to take a look at this tomorrow (Friday 13th)

lemunozm · 2026-02-12T14:23:35Z

Yeah, it seems like crosschain.py is missing in this PR

Adds CrossChainTestManager used by deploy.py for crosschaintest:hub and crosschaintest:spoke steps. Was missing from the branch despite deploy.py already importing it.

gpmayorga · 2026-02-13T14:51:52Z

crosschain.py added

Modified the AnvilManager class to pass additional parameters (network_name, port, dst_cfg, chain_id) to the AnvilEnv constructor, enhancing its configuration capabilities.

gpmayorga · 2026-02-13T15:00:44Z

Fixed the anvil deployments and updated the branch from main. IMO this is ready to go

Updated the CrossChainTestManager to support a full 4-step cross-chain test sequence, including asset registration, hub setup, relay waiting, and share class testing. Added new command options for streamlined execution and improved documentation in README.md for clarity on usage. Adjusted argument parsing to include new test phases.

Consolidated the creation of environment files for Sepolia and Arbitrum Sepolia in the AnvilManager class. This change ensures both environment files are created upfront

- Override protocolAdmin/opsAdmin in anvil env with anvil account addresses so OpsGuardian/ProtocolGuardian accept calls from the deployer (fixes NotTheAuthorizedSafe) - Remove stray undefined `verifier` reference (would crash with NameError) - Use --disable-block-gas-limit for anvil forks (Arbitrum gas model inflates estimates beyond any fixed limit) - Remove redundant WireAdapters step (FullDeployer already wires adapters during deploy:full) - Fix verification to extract address from contract entry dict (was passing the full {address, blockNumber, txHash} object)

lemunozm

Good job here to both @wischli and @gpmayorga! LGTM!!

wischli · 2026-02-17T08:00:40Z

Thanks for cleaning up after my slight mess @gpmayorga 🫶

gpmayorga and others added 30 commits October 17, 2025 19:07

Improve anvil deployment with dual-fork support

5a54109

Refactor AnvilManager to use structured account data and improve key …

ee91fbc

…management

Merge remote-tracking branch 'origin/main' into anvil-improvements

8f4e55d

Enhance deployment error handling and configuration updates

01a9a81

Refactor deploy script to enhance deployment steps and validation

21927e9

- Updated argument validation to support new deployment steps and improved error handling. - Enhanced wiring logic for adapters, including support for multiple connected networks.

Merge branch 'anvil-improvements' into multi-chain-tests

81c8985

Merge remote-tracking branch 'origin/main' into multi-chain-tests

fd697ce

add cross-chain tests to deploy.py

fc9b8e7

latest testnets deployment

afe55f1

update cross-chain readme (AI)

29bc16a

change deploy to deploy to all testnets

937edaf

standardize deploymentInfo

54f18ed

fix: discover pool & share tokens on spoke

c39b28e

fix: trigger refund escrow deploy in spoke script if missing

0c7998c

rewire for arbitrum-sepolia Axelar adapter

8bc1501

run dry-run when PR changes for deploy testnsets

c3c331c

Refactor deployment steps in deploy.py and related files

22709bc

- Updated deployment step from "deploy:all" to "deploy:testnets" for clarity and consistency. - Implemented dry-run mode to skip verification and state saving during test deployments.

redeploy and re-wire adapters

16aa5bf

feat: v3.1 Spell Validator PoC (#16)

87fc5a2

deploy fixes (#14)

b2eea1d

add setEpochIds to use in the migration (#21)

e33d353

deployment changes to support the migration (#22)

ce27a02

fix import script when name is after ../ (#25)

dbfbda4

fix: hook address mismatch (#30)

acc05d4

wischli added 4 commits February 10, 2026 15:34

script: minor improvements

b3bbbcb

Merge remote-tracking branch 'origin/main' into multi-chain-tests-v3

d6649e0

fmt

50ae900

ref: cleanup, rm v1 of isolated tests

16f4f8f

wischli self-assigned this Feb 10, 2026

wischli added ✅ test 🚀 deploy labels Feb 10, 2026

chore: rm env changes (probably outdated at this point)

9beffab

wischli requested review from gpmayorga and lemunozm February 10, 2026 16:44

lemunozm reviewed Feb 12, 2026

View reviewed changes

lemunozm mentioned this pull request Feb 12, 2026

Cross chain tests (#13 internal) #767

Closed

2 tasks

add crosschain test orchestration (ported from protocol-internal PR #13)

664d8cb

Adds CrossChainTestManager used by deploy.py for crosschaintest:hub and crosschaintest:spoke steps. Was missing from the branch despite deploy.py already importing it.

gpmayorga force-pushed the multi-chain-tests-v3 branch from 5646dd9 to 664d8cb Compare February 13, 2026 14:51

gpmayorga added 2 commits February 13, 2026 16:00

fix: update AnvilEnv initialization to include network parameters

ec329dd

Modified the AnvilManager class to pass additional parameters (network_name, port, dst_cfg, chain_id) to the AnvilEnv constructor, enhancing its configuration capabilities.

Merge branch 'main' into multi-chain-tests-v3

21a7d14

gpmayorga and others added 5 commits February 13, 2026 16:15

chore: sync crosschain & readme

ae4a375

docs: rm hardcoded addresses

ff504d2

refactor: create arbitrum-sepolia anvil env file before hand

54898d5

Consolidated the creation of environment files for Sepolia and Arbitrum Sepolia in the AnvilManager class. This change ensures both environment files are created upfront

lemunozm approved these changes Feb 17, 2026

View reviewed changes

wischli merged commit 7893125 into main Feb 17, 2026
13 of 14 checks passed

wischli deleted the multi-chain-tests-v3 branch February 17, 2026 08:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Isolated Adapter Cross-Chain Tests#775

feat: Isolated Adapter Cross-Chain Tests#775
wischli merged 73 commits intomainfrom
multi-chain-tests-v3

wischli commented Feb 10, 2026

Uh oh!

wischli commented Feb 10, 2026

Uh oh!

lemunozm left a comment •

edited

Loading

Uh oh!

lemunozm Feb 12, 2026

Uh oh!

lemunozm Feb 12, 2026 •

edited

Loading

Uh oh!

gpmayorga commented Feb 12, 2026

Uh oh!

lemunozm commented Feb 12, 2026

Uh oh!

gpmayorga commented Feb 13, 2026

Uh oh!

gpmayorga commented Feb 13, 2026 •

edited

Loading

Uh oh!

lemunozm left a comment

Uh oh!

wischli commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wischli commented Feb 10, 2026

Product requirements

Design notes

Uh oh!

wischli commented Feb 10, 2026

Uh oh!

lemunozm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lemunozm Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

lemunozm Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gpmayorga commented Feb 12, 2026

Uh oh!

lemunozm commented Feb 12, 2026

Uh oh!

gpmayorga commented Feb 13, 2026

Uh oh!

gpmayorga commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lemunozm left a comment

Choose a reason for hiding this comment

Uh oh!

wischli commented Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lemunozm left a comment •

edited

Loading

lemunozm Feb 12, 2026 •

edited

Loading

gpmayorga commented Feb 13, 2026 •

edited

Loading