Update SPEC file to build on CentOS #152
Conversation
Manage different package names and versions to support
different openSUSE/SLES versions and CentOS for OBS.
Do not use the %makeinstall marko, it does not expand correctly
for CentOS. CentOS also needs to create %{buildroot}%{_libdir} to
install correctly within the RPM build system.
Signed-off-by: Danny Al-Gaaf <[email protected]>
Co-authored-by: Giacomo Tenaglia <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
| # Foundation. See file COPYING. | ||
|
|
||
| %{!?dovecot_devel: %define dovecot_devel dovecot22-devel} | ||
| %{!?librados_version: %define librados_version 10.2.5} |
There was a problem hiding this comment.
Minimum RADOS version is 12.2.0
There was a problem hiding this comment.
Is it really? What is missing in 10.2.5? No objection, I'm fine with the requirement, I would like only to understand it.
There was a problem hiding this comment.
The plugin is not tested with 10.2.5, all our dev, unit and integration tests are running against luminous 12.2.0. Last time i checked, i also ran into some runtime issues with the storage and dictionary plugin using the 10.2.5 on a suse test server with imaptest. However this may already be fixed because we changed a lot since then. I checked the build against 10.2.5 and it builds fine and tests are working also, so i guess it's possible to use the 10.2.5 as minimum now, but i would recommend to set the minimum to 12.2.0 cause this is the minimum version we are working with and supporting in the future.
| Group: Productivity/Networking/Email/Servers | ||
| License: LGPL-2.1 | ||
| Source: %{name}_%{version}-%{release}.tar.gz | ||
| Source: %{name}-%{version}.tar.xz |
There was a problem hiding this comment.
This would break the Deutsche Telekom build we are using. Is it possible to overwrite "Source" from the outside?
There was a problem hiding this comment.
"from the outside" means?
There was a problem hiding this comment.
The point is that make_dist.sh builds by default a %{name}-%{version}.tar.xz
There was a problem hiding this comment.
For the DTAG build we have to modify several path names to adhere to their internal standards. These path names are overridden by the script that is executing the build process. To avoid collision with potential OS packages we use %{release}, which a standard field, to mark a custom build. If you don't mind, I would suggest changes to make_dist.sh to support a release or dist, to not break our established build process
rpm/dovecot-ceph-plugin.spec
Outdated
| Source: %{name}-%{version}.tar.xz | ||
|
|
||
| Provides: dovecot-ceph-plugin = %{version}-%{release} | ||
| Provides: dovecot-ceph-plugins = %{version}-%{release} |
There was a problem hiding this comment.
This change is not consistent. The RPM name remains dovecot-ceph-plugin. Also, the path names for includes etc. still use the singular form. To allow updates you should include "Obsoletes" or alike.
| %attr(0755, root, root) %{_bindir}/rmb | ||
| %doc %{_mandir}/man1/rmb.1* | ||
| %{_bindir}/rmb | ||
| /usr/share/man/man1/rmb.1.gz |
There was a problem hiding this comment.
Please, do not use absolute path names. We have to relocate them using the macros.
Special thanks to @giacomd for working out the issue with _libdir. This should close issue #145