Skip to content

Add pre_condtime for preconditioning and allow multiple randrw workloads within the same YAML #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lee-j-sanders wants to merge 4 commits into from
Closed

Add pre_condtime for preconditioning and allow multiple randrw workloads within the same YAML #326

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18e5bbe
Add a yotal_iodepth option to be slit over total volumes
Jan 30, 2025
cee02b9
Workload fixes for total_iodepth
Feb 6, 2025
83f637c
This commit addresses the following
lee-j-sanders Feb 11, 2025
b0c45ba
Add precond_time to the test_bm_librbdfio.py
lee-j-sanders Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions benchmark/librbdfio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ def __init__(self, archive_dir, cluster, config):
self.recov_test_type = config.get('recov_test_type', 'blocking')
self.data_pool_profile = config.get('data_pool_profile', None)
self.time = config.get('time', None)
self.precond_time = config.get('precond_time',None )
Copy link
Contributor

@perezjosibm perezjosibm Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the way workloads work, basically they temporarily overwrite the global FIO options defined in the test plan .yaml (normally located before the workloads section). So within a precondition one can set a time value that only affects the precondition, which is then restored to the global. Then, another workload step would do the same.

In other words, there is not actual need to introduce yet another 'precond_time'!

But you can do the experiment: define two different time values in a precond and a workload step, from the global ones, with the existing code (that is, without this change) to convince yourself.

Copy link
Contributor

@perezjosibm perezjosibm Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is also mentioned in the documentation https://github.com/ceph/cbt/blob/master/docs/Workloads.md


# Global FIO options can be overwritten for specific workload options
# would be nice to have them as a separate class -- future PR
self.time_based = bool(config.get('time_based', False))
Expand Down Expand Up @@ -187,18 +189,36 @@ def run_workloads(self):
self.mode = test['mode']
if 'op_size' in test:
self.op_size = test['op_size']
if 'precond' in test:
fioruntime = self.precond_time
else:
fioruntime = self.time

self.mode = test['mode']
self.numjobs = job
self.iodepth = iod
self.run_dir = ( f'{self.base_run_dir}/{self.mode}_{int(self.op_size)}/'
f'iodepth-{int(self.iodepth):03d}/numjobs-{int(self.numjobs):03d}' )

# Needed to allow for different mixed ratio results with the same block size, we
# store the ratio within the directory name. Otherwise workloads would only support
# 1 mixed workload for a given block size. For 100% read, 100% write don't need to
# store the read/write ratio.

if self.mode == 'randrw':
self.rwmixread = test['rwmixread']
self.rwmixwrite = 100 - self.rwmixread
self.run_dir = ( f'{self.base_run_dir}/{self.mode}{self.rwmixread}{self.rwmixwrite}_{int(self.op_size)}/'
f'iodepth-{int(self.iodepth):03d}/numjobs-{int(self.numjobs):03d}' )
else:
self.run_dir = ( f'{self.base_run_dir}/{self.mode}_{int(self.op_size)}/'
f'iodepth-{int(self.iodepth):03d}/numjobs-{int(self.numjobs):03d}' )

common.make_remote_dir(self.run_dir)

number_of_volumes: int = int(self.volumes_per_client)
if use_total_iodepth:
number_of_volumes = len(self._ioddepth_per_volume.keys())
for i in range(number_of_volumes):
fio_cmd = self.mkfiocmd(i)
fio_cmd = self.mkfiocmd(i,fioruntime)
p = common.pdsh(settings.getnodes('clients'), fio_cmd)
ps.append(p)
if enable_monitor:
Expand Down Expand Up @@ -253,7 +273,7 @@ def run(self):
if self._ioddepth_per_volume != {}:
number_of_volumes = len(self._ioddepth_per_volume.keys())
for i in range(number_of_volumes):
fio_cmd = self.mkfiocmd(i)
fio_cmd = self.mkfiocmd(i,self.time)
p = common.pdsh(settings.getnodes('clients'), fio_cmd)
ps.append(p)
for p in ps:
Expand All @@ -269,8 +289,7 @@ def run(self):
common.sync_files(f'{self.run_dir}/*', self.out_dir)
self.analyze(self.out_dir)


def mkfiocmd(self, volnum: int) -> str:
def mkfiocmd(self, volnum: int, time) -> str:
"""
Construct a FIO cmd (note the shell interpolation for the host
executing FIO).
Expand All @@ -291,8 +310,8 @@ def mkfiocmd(self, volnum: int) -> str:
fio_cmd += ' --output-format=%s' % self.fio_out_format
if (self.mode == 'readwrite' or self.mode == 'randrw'):
fio_cmd += ' --rwmixread=%s --rwmixwrite=%s' % (self.rwmixread, self.rwmixwrite)
if self.time is not None:
fio_cmd += ' --runtime=%d' % self.time
if time is not None:
fio_cmd += ' --runtime=%d' % time
if self.time_based is True:
fio_cmd += ' --time_based'
if self.ramp is not None:
Expand Down