Skip to content

Commit 00bd46f

Browse files
committed
ci: fix errcheck in golangci-lint
in latest version of golangci-lint we need to check all the errors, This commit fixes the same in test files. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
1 parent ca114a4 commit 00bd46f

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

test/e2e/e2e_suite_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ import (
2727
// Run e2e tests using the Ginkgo runner.
2828
func TestE2E(t *testing.T) {
2929
RegisterFailHandler(Fail)
30-
fmt.Fprintf(GinkgoWriter, "Starting ceph-csi-operator suite\n")
30+
_, err := fmt.Fprintf(GinkgoWriter, "Starting ceph-csi-operator suite\n")
31+
if err != nil {
32+
t.Fatalf("Failed to write to GinkgoWriter: %v", err)
33+
}
3134
RunSpecs(t, "e2e suite")
3235
}

test/utils/utils.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ const (
3535
)
3636

3737
func warnError(err error) {
38-
fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
38+
_, fErr := fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
39+
if fErr != nil {
40+
panic(fErr)
41+
}
3942
}
4043

4144
// InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -53,12 +56,18 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
5356
cmd.Dir = dir
5457

5558
if err := os.Chdir(cmd.Dir); err != nil {
56-
fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
59+
_, fErr := fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
60+
if fErr != nil {
61+
panic(fErr)
62+
}
5763
}
5864

5965
cmd.Env = append(os.Environ(), "GO111MODULE=on")
6066
command := strings.Join(cmd.Args, " ")
61-
fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
67+
_, err := fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
68+
if err != nil {
69+
return nil, err
70+
}
6271
output, err := cmd.CombinedOutput()
6372
if err != nil {
6473
return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))

0 commit comments

Comments
 (0)