api: update api version to v1beta1#216
Closed
black-dragon74 wants to merge 7 commits intoceph:mainfrom
Closed
Conversation
This patch updates the API version from v1alpha1 to v1beta1 Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74
force-pushed
the
alpha-to-beta
branch
from
28613a1 to
eb36383
Compare
Collaborator
|
@black-dragon74 have you tested this change? the ceph-csi-operator should surve both Alpha and Beta API's as we already have clusters for Alpha CRD. |
nb-ohad
reviewed
Mar 19, 2025
Collaborator
nb-ohad
left a comment
nb-ohad
left a comment
There was a problem hiding this comment.
I believe that the PR is missing a conversion webhook. Without it k8s will not be able to convert forward and backward between the two version (even if the are identical)
Have we tested having a v1beta1 CR served as a v1alpha1 CR?
Member
Author
Closing this one and following it at: #218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This patch updates the API version from
v1alpha1tov1beta1Closes: #43