nvmeof: add rados ns ability #5866
Merged
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadididi
force-pushed
the
nvmeof/add_rados_ns
branch
from
8bc3c9e to
86c2c5d
Compare
nixpanic
reviewed
Dec 18, 2025
Member
nixpanic
left a comment
nixpanic
left a comment
There was a problem hiding this comment.
lgtm, but please check the inline comment for improved usability and coding guidelines.
gadididi
force-pushed
the
nvmeof/add_rados_ns
branch
from
86c2c5d to
388fae0
Compare
nixpanic
reviewed
Dec 18, 2025
gadididi
force-pushed
the
nvmeof/add_rados_ns
branch
2 times, most recently
from
67e64c0 to
bdd2622
Compare
nixpanic
approved these changes
Dec 18, 2025
add rados ns ability to nvmeof csi driver. Signed-off-by: gadi-didi <[email protected]>
nixpanic
force-pushed
the
nvmeof/add_rados_ns
branch
from
bdd2622 to
cfb02e2
Compare
nixpanic
approved these changes
Jan 6, 2026
Madhu-1
approved these changes
Jan 7, 2026
78 tasks
Contributor
Merge Queue Status✅ The pull request has been merged at cfb02e2 This pull request spent 34 minutes 9 seconds in the queue, including 33 minutes 56 seconds running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RADOS namespace ability to nvmeof csi driver.
RADOS namespace support was added to nvmeof GW project.
RADOS namespace option in create volume step is added.
Is there anything that requires special attention
It is known the ceph-csi instance (deployment) is working with only 1 RADOS namespace. And can be more than 1 deployment on same Ceph cluster. Each of deployment has different rados ns.
RADOS namespace value is defined in rbd config-map, in that way, the nvmeof controller fetch the value from the rbd response,
and then calls to create nvmeof namespace later.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)