merge queue: embarking devel (dead2e5) and #5899 together #5904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we fetch the volumeId's from VGRContent.Spec.Source which has all the volumes that should be part of the group. But, it might happen that the initial modify call might fail due to some reason like network/config issue. In that case, the volumegroup omap will already be updated with the volumeIds and subsequent ModifyVolumeGroup call will fail as the volumes before and after Modify operation is same. Therefore, we should fetch the volumeIds from the VGRContent status, which only gets updated post a succesfull modification. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
ceph-csi-bot
added
component/rbd
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.32 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch devel (dead2e5) and #5899 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #5899.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]base=develstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkstatus-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/k8s-e2e-external-storage/1.34status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e-helm/k8s-1.34status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.34status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdlabel=ci/skip/e2ebase~=^(release-.+)$label=ci/skip/e2estatus-success=ci/centos/k8s-e2e-external-storage/1.31status-success=ci/centos/mini-e2e-helm/k8s-1.31status-success=ci/centos/mini-e2e/k8s-1.31status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/k8s-e2e-external-storage/1.33status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e-helm/k8s-1.33status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.33status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkbase=release-v3.14label=ci/skip/e2estatus-success=ci/centos/k8s-e2e-external-storage/1.30status-success=ci/centos/k8s-e2e-external-storage/1.31status-success=ci/centos/mini-e2e-helm/k8s-1.30status-success=ci/centos/mini-e2e-helm/k8s-1.31status-success=ci/centos/mini-e2e/k8s-1.30status-success=ci/centos/mini-e2e/k8s-1.31status-success=ci/centos/k8s-e2e-external-storage/1.32status-success=ci/centos/mini-e2e-helm/k8s-1.32status-success=ci/centos/mini-e2e/k8s-1.32status-success=ci/centos/upgrade-tests-cephfsstatus-success=ci/centos/upgrade-tests-rbdstatus-success=codespellstatus-success=go-teststatus-success=golangci-lintstatus-success=lint-extrasstatus-success=mod-checkstatus-success=multi-arch-buildstatus-success=uncommitted-code-checkbase=ci/centosstatus-success=ci/centos/jjb-validatestatus-success=ci/centos/job-validationRequired conditions to stay in the queue:
#approved-reviews-by >= 2[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]