nvmeof: add retry mechanism for listenerList #6038
Open
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding retry mechanism for listenerList grpc call because there is unknowm (under investigation) issue in the nvmeof gw, when user creates subsystem with autoListener option (it creates the listener automatically) but then, when the controller wants to retrieve the listeners list, it gets empty list. there is some delay in the GW. Signed-off-by: gadi-didi <gadi.didi@ibm.com>
Madhu-1
reviewed
Feb 11, 2026
|
|
||
| return ConvertListenersFromProto(autoListeners.GetListeners()), nil | ||
| }, | ||
| retry.Attempts(6), // ~100ms, 200ms, 400ms, 800ms, 1.6s, 3.2s = ~6.3s total |
Collaborator
There was a problem hiding this comment.
@gadididi will this work in all the clusters where we have 100 pvc etc or if ceph cluster is under some small stress? because retries are always very tricky
Contributor
Author
There was a problem hiding this comment.
I will try to check it soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
adding retry mechanism for listenerList grpc call
because there is unknown (under investigation) issue in the nvmeof gw, when user creates subsystem with autoListener option (it creates the listener automatically) but then, when the controller wants to retrieve the listeners list, it gets empty list. there is some
delay in the GW.
FYI- the listeners list comes from the ceph mon command
nvme-gw listeners.Related issues
fixed:
#6037
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)