Skip to content

rgw/admin : add account support in go-ceph #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Jan 21, 2026
Merged

rgw/admin : add account support in go-ceph #1211

mergify merged 1 commit into from
Jan 21, 2026

Conversation

@thotz
Copy link
Collaborator

@thotz thotz commented Dec 18, 2025 •
edited by anoopcs9
Loading

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@thotz thotz force-pushed the rgw-add-adminops-account-support branch from ca9b4ef to 5a5c4d9 Compare December 18, 2025 13:56
cbodley
cbodley reviewed Dec 18, 2025
View reviewed changes
Copy link

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thotz thotz force-pushed the rgw-add-adminops-account-support branch from 5a5c4d9 to 9f39711 Compare December 18, 2025 14:09
@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented Dec 18, 2025

If we ignore the reef failures (CI/infra issues) the other failures are in the rgw suite and probably related to your changes, PTAL. Thanks!

@thotz
Copy link
Collaborator Author

thotz commented Dec 18, 2025

If we ignore the reef failures (CI/infra issues) the other failures are in the rgw suite and probably related to your changes, PTAL. Thanks!

Will take a look Thanks

@thotz thotz force-pushed the rgw-add-adminops-account-support branch 3 times, most recently from 5e26919 to 7526421 Compare December 19, 2025 03:03
anoopcs9
anoopcs9 requested changes Dec 19, 2025
View reviewed changes
@thotz thotz force-pushed the rgw-add-adminops-account-support branch 2 times, most recently from 5653349 to c2a05e7 Compare December 19, 2025 16:59
@thotz thotz force-pushed the rgw-add-adminops-account-support branch from c2a05e7 to aaed5d0 Compare January 7, 2026 07:25
anoopcs9
anoopcs9 requested changes Jan 7, 2026
View reviewed changes
@thotz thotz force-pushed the rgw-add-adminops-account-support branch from aaed5d0 to 02fcaa3 Compare January 8, 2026 09:53
@thotz thotz requested a review from anoopcs9 January 8, 2026 09:54
@thotz thotz force-pushed the rgw-add-adminops-account-support branch from 02fcaa3 to 1caae80 Compare January 8, 2026 12:35
@anoopcs9
Copy link
Collaborator

anoopcs9 commented Jan 8, 2026

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jan 8, 2026

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the rgw-add-adminops-account-support branch from 1caae80 to dce3d35 Compare January 8, 2026 13:36
@thotz thotz mentioned this pull request Jan 9, 2026
Draft
6 tasks
@thotz thotz force-pushed the rgw-add-adminops-account-support branch 2 times, most recently from 5dac356 to dd7cbc3 Compare January 14, 2026 11:04
anoopcs9
anoopcs9 requested changes Jan 14, 2026
View reviewed changes
@thotz thotz force-pushed the rgw-add-adminops-account-support branch from dd7cbc3 to 1d6850c Compare January 14, 2026 12:10
anoopcs9
anoopcs9 requested changes Jan 15, 2026
View reviewed changes
@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Jan 15, 2026
@anoopcs9 anoopcs9 force-pushed the rgw-add-adminops-account-support branch from 5e723b8 to 5c6ce71 Compare January 16, 2026 10:46
anoopcs9
anoopcs9 requested changes Jan 16, 2026
View reviewed changes
@thotz thotz force-pushed the rgw-add-adminops-account-support branch from 5c6ce71 to 5e5c6c4 Compare January 16, 2026 11:14
@thotz thotz requested a review from anoopcs9 January 16, 2026 11:15
anoopcs9
anoopcs9 previously approved these changes Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

phlogistonjohn
phlogistonjohn reviewed Jan 16, 2026
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it looks OK to me but I have a question on the quota related fields in the struct.

@thotz thotz force-pushed the rgw-add-adminops-account-support branch from 5e5c6c4 to 7972422 Compare January 20, 2026 12:37
@thotz thotz requested a review from phlogistonjohn January 20, 2026 12:37
@mergify mergify bot dismissed anoopcs9’s stale review January 20, 2026 12:38

Pull request has been modified.

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Jan 21, 2026

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jan 21, 2026

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 force-pushed the rgw-add-adminops-account-support branch from 7972422 to 7ff6bc2 Compare January 21, 2026 05:36
@thotz thotz force-pushed the rgw-add-adminops-account-support branch from 7ff6bc2 to 77671d1 Compare January 21, 2026 05:58
@anoopcs9 anoopcs9 added extended-review A submitter or reviewer feels the PR needs an extended review period and removed extended-review A submitter or reviewer feels the PR needs an extended review period labels Jan 21, 2026
phlogistonjohn
phlogistonjohn approved these changes Jan 21, 2026
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@mergify mergify bot added the queued label Jan 21, 2026
@mergify mergify bot merged commit 504c367 into ceph:master Jan 21, 2026
17 checks passed
@mergify
Copy link

mergify bot commented Jan 21, 2026

Merge Queue Status

✅ The pull request has been merged at 77671d1

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check
    • check-neutral = check
    • check-skipped = check
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (pacific)
    • check-neutral = test-suite (pacific)
    • check-skipped = test-suite (pacific)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (quincy)
    • check-neutral = test-suite (quincy)
    • check-skipped = test-suite (quincy)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (reef)
    • check-neutral = test-suite (reef)
    • check-skipped = test-suite (reef)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (squid)
    • check-neutral = test-suite (squid)
    • check-skipped = test-suite (squid)

@mergify mergify bot removed the queued label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbodley cbodley cbodley left review comments

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees

No one assigned

Labels

API This PR includes a change to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thotz @phlogistonjohn @anoopcs9 @cbodley