test_get_object_torrent: treat response body as bytes#726
Open
drey123 wants to merge 1 commit intoceph:masterfrom
Open
test_get_object_torrent: treat response body as bytes#726drey123 wants to merge 1 commit intoceph:masterfrom
drey123 wants to merge 1 commit intoceph:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #725
Torrent files are binary (bencode with raw SHA1 digests in the pieces field), so the test should not decode the response body as UTF-8.
This change makes
test_get_object_torrentcompare bytes safely when a backend returns an actual torrent body.