Closed
Conversation
…on, result returns as set of values. missing memory managment for variable and value Signed-off-by: gal salomon <gal.salomon@gmail.com>
2 main flows (1) non-aggregation flow: split the input object into N ranges, each range gets its own context. (2) aggregarion flow:(for aggregatio queries) requires 2 phases, Upon the completion of the first phase (running the query on a specific range) The AST will be traversed for aggregation nodes, the result of each node is pushed into a dedicated scratch area current commit is handling the CSV use-case/non-aggregation flow.
Author
|
#103 is handling the parallel execution. it takes a different approach(the caller splits the input or defines many input streams as a single one). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 main flows
(1) non-aggregation flow: split the input object into N ranges, each range gets its own context.
(2) aggregation flow:(for aggregation queries) requires 2 phases,
Upon the completion of the first phase (running the query on a specific range)
The AST will be traversed for aggregation nodes, the result of each node is pushed into a dedicated scratch area
the second phase will use the result of the first phase.
The AST for the second phase will be refactored.