setup.cfg: fix teuthology-openstack dependency#2074
Merged
Conversation
The PR ceph#2050 "Revive teuthology-openstack" introduced new dependency after refactoring partly of teuthology.openstack instance classes to use api instead of command line. However the openstacksdk added to wrong section options.extras_require.openstack, that intended to be used for provisioning openstack nodes via libcloud, which is optional and is not installable by default. I.e. `pip install -e ".[openstack]"` must be used in order to get it. However the refactoring forced unconditional openstack requirement. That's why this dependency should go to options.install_requires in order to make `pip install -e .` work again. Fixes: 252ab4f Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #2050 "Revive teuthology-openstack" introduced new dependency after refactoring partly of teuthology.openstack instance classes to use api instead of command line. However the openstacksdk added to wrong section options.extras_require.openstack, that intended to be used for provisioning openstack nodes via libcloud, which is optional and is not installable by default.
I.e.
pip install -e ".[openstack]"must be used in order to get it.However the refactoring forced unconditional openstack requirement.
That's why this dependency should go to options.install_requires in order to make
pip install -e .work again.Fixes: 252ab4f