Adding check for shaman and chacra build validations - #2095
Closed
tintumathew10 wants to merge 1 commit into
Closed
Conversation
tintumathew10
requested review from
amathuria and
kamoltat
and removed request for
a team
October 17, 2025 12:14
tintumathew10
force-pushed
the
build_comp
branch
2 times, most recently
from
October 24, 2025 12:51
5e2132a to
2a7cd6c
Compare
tintumathew10
force-pushed
the
build_comp
branch
22 times, most recently
from
December 3, 2025 14:16
10184f1 to
a5b3871
Compare
Signed-off-by: tintumathew10 <tmathew@redhat.com>
tintumathew10
force-pushed
the
build_comp
branch
from
December 4, 2025 04:03
a5b3871 to
f55a11c
Compare
zmc
requested changes
Dec 10, 2025
zmc
left a comment
zmc
left a comment
Member
There was a problem hiding this comment.
I added a couple feedback items but before we get too deep into this, could you explain a little about the reasoning behind adding this instead of modifying or replacing this bit: https://github.com/ceph/teuthology/blob/main/teuthology/suite/util.py#L226-L256
Thanks!
| return None | ||
| return response.text | ||
|
|
||
| chacra_url = f"https://1.chacra.ceph.com/repos/ceph/{ceph_branch}/" |
Member
There was a problem hiding this comment.
The chacra URL should not be hardcoded; it should be discovered via the shaman API, I think.
| msg = f"Not found in Chacra for branch {ceph_branch}." | ||
| util.schedule_fail(msg, self.name, dry_run=self.args.dry_run) | ||
|
|
||
| shaman_url = f"https://shaman.ceph.com/builds/ceph/{ceph_branch}/" |
Member
There was a problem hiding this comment.
This should not be hardcoded and should instead use config.shaman_host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for checking the selected sha1 from github is existing in shaman and chacra.