Closed
Conversation
If there is an error in lua script at postmerge stage teuthology-suite unexpectedly drops exception and exits. However, we better print exception and go on with our suite, just filter out the failed case. Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
kshtsk
requested review from
VallariAg and
amathuria
and removed request for
a team
Member
|
I don't love this idea as it could cause us to unintentionally miss out on testing features in case of malformed or buggy yaml |
Contributor
Author
@zmc makes sense... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is an error in lua script at postmerge stage teuthology-suite unexpectedly drops exception and exits.
However, we better print exception and go on with our suite, just filter out the failed case.