lock: get OS info from lock server first to determine username#2120
Open
lock: get OS info from lock server first to determine username#2120
Conversation
Try to get OS type from lock server before creating Remote object in update_nodes(). This allows us to determine the correct SSH username (root for RPM-based distros, ubuntu for Debian-based) before attempting to connect, avoiding connection failures due to wrong username. Changes: - Add _get_username_for_os_type() helper function - Query lock server for OS info in update_nodes() - Create Remote with correct username based on OS type - Add fallback logic if connection fails with determined username This fixes issues where update_nodes() fails on CentOS/RHEL machines because it tries to connect with default 'ubuntu' username instead of 'root'. Signed-off-by: deepssin <deepssin@redhat.com>
deepssin
requested review from
kamoltat and
zmc
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to get os type from lock server before creating Remote object in update_nodes(). This allows us to determine the correct SSH username (root for RPM-based distros, ubuntu for Debian-based) before attempting to connect . avoiding connection failures due to wrong username.
Changes -
This fixes issues where update_nodes() fails on CentOS/RHEL machines because it tries to connect with default
ubuntuusername instead of 'root'.