Skip to content

Fixing find_first #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olance wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing find_first #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c47a99a
New specs to enforce adapter's API
olance Aug 26, 2014
6dcbd3d
Make the tests pass again
olance Aug 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/cequel/record/orm_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ def get(key_values)
# none present
#
def find_first(options = {})
construct_scope(options).first
scope = construct_scope(options)
if scope.is_a?(Record)
scope.exists? ? scope : nil
else
scope.first
end
end

#
Expand Down
10 changes: 10 additions & 0 deletions spec/examples/orm_adapter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@
post_adapter.find_first(conditions: {blog_subdomain: 'postgres'})
.should == other_post
end

it 'should find first when there is only a single record present' do
expect(blog_adapter.find_first(conditions: { subdomain: 'cassandra' }))
.to eq(blog)
end

it 'should return nil if no record could be found' do
expect(blog_adapter.find_first(conditions: { subdomain: 'nope' }))
.to be_nil
end

it 'should find first with secondary index condition' do
post_adapter.find_first(conditions: {author_id: 1})
Expand Down